New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance, dependencies, and improvements #14

Merged
merged 2 commits into from Jul 16, 2014

Conversation

Projects
None yet
2 participants
@renoirb
Contributor

renoirb commented Jul 15, 2014

Maintenance

  • Renamed deprecated component.json for an updated bower.json
  • Tested with latest jQuery, removed version blocker
  • Some documentation improvements
  • Removed trailing spaces

Improvements

  • Fake user doesn’t rely on web service anymore, but through localUserThesaurus
  • Added localUsers in roughdraft.thesaurus.json for localUserThesaurus
  • Refactored test/ examples, removed checked-in jQuery requirement, called more recent jQuery from CDN

TODO

  • Create tag to upstream ndreckshage to 0.1.5 as bower.json is declaring it
  • Minify jquery.roughdraft.js into jquery.roughdraft.min.js

Soon

Next objective: Propose default configuration that doesn’t require ANY HTTP calls for images, users, text.

Also:

Maintenance, dependencies, and improvements
* Tested with latest jQuery, removed version blocker
* Some documentation improvements
* Removed trailing spaces
* Fake user doesn’t rely on [web service](http://www.roughdraftjs.com/api/) anymore, but through `localUserThesaurus`
* Added `localUsers` in  `roughdraft.thesaurus.json` for `localUserThesaurus`
* Refactored test/ examples
@renoirb

This comment has been minimized.

Show comment
Hide comment
@renoirb

renoirb Jul 15, 2014

Contributor

Note, the merge conflict is only in the README.md at the document title :/

Contributor

renoirb commented Jul 15, 2014

Note, the merge conflict is only in the README.md at the document title :/

@ndreckshage

This comment has been minimized.

Show comment
Hide comment
@ndreckshage

ndreckshage Jul 15, 2014

Owner

@renoirb this is great I'll take a look tonight + merge in.

Owner

ndreckshage commented Jul 15, 2014

@renoirb this is great I'll take a look tonight + merge in.

@renoirb

This comment has been minimized.

Show comment
Hide comment
@renoirb

renoirb Jul 15, 2014

Contributor

Cool. Please have a look at bower.json file, at authors. Forgot to add other ones you put in the readme. Feel free to not put me.

Also, be aware that i'm going to promote the use of RoughDraft for WebPlatform.org rework i'm going to start soon.

Contributor

renoirb commented Jul 15, 2014

Cool. Please have a look at bower.json file, at authors. Forgot to add other ones you put in the readme. Feel free to not put me.

Also, be aware that i'm going to promote the use of RoughDraft for WebPlatform.org rework i'm going to start soon.

ndreckshage added a commit that referenced this pull request Jul 16, 2014

Merge pull request #14 from renoirb/201407-maintenance
Maintenance, dependencies, and improvements

@ndreckshage ndreckshage merged commit 207a057 into ndreckshage:master Jul 16, 2014

@ndreckshage

This comment has been minimized.

Show comment
Hide comment
@ndreckshage

ndreckshage Jul 16, 2014

Owner

nice, im going to make a few minor changes to readme etc. also make a few issues for future contributors. i think it would be nice to get rid of jquery dependency all together

Owner

ndreckshage commented Jul 16, 2014

nice, im going to make a few minor changes to readme etc. also make a few issues for future contributors. i think it would be nice to get rid of jquery dependency all together

@ndreckshage

This comment has been minimized.

Show comment
Hide comment
@ndreckshage

ndreckshage Jul 16, 2014

Owner

and btw @renoirb you might be interested in another project im working on -- https://github.com/frontendperformance/isomorphic -- although that is still very early

Owner

ndreckshage commented Jul 16, 2014

and btw @renoirb you might be interested in another project im working on -- https://github.com/frontendperformance/isomorphic -- although that is still very early

@ndreckshage

This comment has been minimized.

Show comment
Hide comment
@ndreckshage

ndreckshage Jul 16, 2014

Owner

i updated it a bit, i thought a bit verbose. split some stuff out into separate .md files / wiki

Owner

ndreckshage commented Jul 16, 2014

i updated it a bit, i thought a bit verbose. split some stuff out into separate .md files / wiki

@renoirb

This comment has been minimized.

Show comment
Hide comment
@renoirb

renoirb Jul 16, 2014

Contributor

Thanks. Don't forget to tag 0.1.5 otherwise bower wont find the release.

Unless you [want me to integrate the SVG image generator](https://twitter.com/ shepazu/status/ 489194617183543297) before we bump version number?

Contributor

renoirb commented Jul 16, 2014

Thanks. Don't forget to tag 0.1.5 otherwise bower wont find the release.

Unless you [want me to integrate the SVG image generator](https://twitter.com/ shepazu/status/ 489194617183543297) before we bump version number?

@renoirb

This comment has been minimized.

Show comment
Hide comment
@ndreckshage

This comment has been minimized.

Show comment
Hide comment
@ndreckshage

ndreckshage Jul 16, 2014

Owner

if you think youll have time within the next week or so. i think svg image gen is nice addition. added new issue #17 and bower at #18

Owner

ndreckshage commented Jul 16, 2014

if you think youll have time within the next week or so. i think svg image gen is nice addition. added new issue #17 and bower at #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment