New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance issues ? #89

Closed
ndunand opened this Issue Feb 17, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@ndunand
Owner

ndunand commented Feb 17, 2016

Possible performance issues, as reported by Sara Cenni on the Moodle.org plugin page.

A quick test with 2000 students revealed no big performance issues, below is the profiling callgraph for the mod/choicegroup/report.php page (displaying users with no response), seeming to indicate the bottleneck to be calculating all users' names for display.

mod_choicegroup-report php_callgraph

@ndunand ndunand changed the title from performance issues to performance issues ? Feb 17, 2016

@s-cenni

This comment has been minimized.

Show comment
Hide comment
@s-cenni

s-cenni Feb 23, 2016

Contributor

Hi Nicolas,
This is my profiling callgraph for mod/choicegroup/view.php with a course with 3647 users.

3647

Below the report with 1547 users

1547

Contributor

s-cenni commented Feb 23, 2016

Hi Nicolas,
This is my profiling callgraph for mod/choicegroup/view.php with a course with 3647 users.

3647

Below the report with 1547 users

1547

@ndunand

This comment has been minimized.

Show comment
Hide comment
@ndunand

ndunand Feb 24, 2016

Owner

Thanks for the callgraphs. Yes indeed, the choicegroup_get_user_answer (called once per enrolled user) seems to be the bottleneck here, as you supposed initially.

Owner

ndunand commented Feb 24, 2016

Thanks for the callgraphs. Yes indeed, the choicegroup_get_user_answer (called once per enrolled user) seems to be the bottleneck here, as you supposed initially.

@ndunand

This comment has been minimized.

Show comment
Hide comment
@ndunand

ndunand Feb 24, 2016

Owner

What about trying to implement the code modification you were talking about? Is this something you could do? If it proves a real improvement and passes all tests, I'd be glad to include it.

Owner

ndunand commented Feb 24, 2016

What about trying to implement the code modification you were talking about? Is this something you could do? If it proves a real improvement and passes all tests, I'd be glad to include it.

@s-cenni

This comment has been minimized.

Show comment
Hide comment
@s-cenni

s-cenni Feb 25, 2016

Contributor

I thought about your proposal, but unfortunately in these weeks I'm too busy to study the plugin code and to implement the code modification. :( In the near future I hope I have enough time to implement it because we really appreciate your plugin and we found it very useful!!
Thank you!
Sara

Contributor

s-cenni commented Feb 25, 2016

I thought about your proposal, but unfortunately in these weeks I'm too busy to study the plugin code and to implement the code modification. :( In the near future I hope I have enough time to implement it because we really appreciate your plugin and we found it very useful!!
Thank you!
Sara

@ndunand

This comment has been minimized.

Show comment
Hide comment
@ndunand

ndunand Feb 25, 2016

Owner

Alright, thanks for posting back. I'm leaving this open so that we can report back here later on.

Owner

ndunand commented Feb 25, 2016

Alright, thanks for posting back. I'm leaving this open so that we can report back here later on.

@bonimat

This comment has been minimized.

Show comment
Hide comment
@bonimat

bonimat May 11, 2016

I'm Sara's collegue . We spoke about the problem few weeks ago, and we have worked on a potential solution.
Do you prefer receive my code by email or do I have to post it in this forum?

bonimat commented May 11, 2016

I'm Sara's collegue . We spoke about the problem few weeks ago, and we have worked on a potential solution.
Do you prefer receive my code by email or do I have to post it in this forum?

@ndunand

This comment has been minimized.

Show comment
Hide comment
@ndunand

ndunand May 12, 2016

Owner

Hi. Thanks, the best for me would be that you initiate a pull request, so I could easily review the changes. See the documentation here: https://help.github.com/articles/using-pull-requests/

Owner

ndunand commented May 12, 2016

Hi. Thanks, the best for me would be that you initiate a pull request, so I could easily review the changes. See the documentation here: https://help.github.com/articles/using-pull-requests/

@ndunand

This comment has been minimized.

Show comment
Hide comment
@ndunand

ndunand Jul 7, 2016

Owner

Addresses by #90

Owner

ndunand commented Jul 7, 2016

Addresses by #90

@ndunand ndunand closed this Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment