New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require sonatype properties to parse build.gradle #3

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rwdalpe

rwdalpe commented Oct 28, 2017

build.gradle could not be interpreted unless sonatypeUsername and
sonatypePassword were present as properties in the project. If either
are missing, just default to empty strings. uploadArchives will of
course fail in such a case, but at least the rest of the script is usable.

Don't require sonatype properties to parse build.gradle
build.gradle could not be interpreted unless `sonatypeUsername` and
`sonatypePassword` were present as properties in the project. If either
are missing, just default to empty strings. `uploadArchives` will of
course fail, but at least the rest of the script is usable.
@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Nov 13, 2017

Owner

I'm slightly confused. I thought I fixed this ages ago by putting the sonatype properties in gradle.properties. Is that not working for you?

Owner

ndw commented Nov 13, 2017

I'm slightly confused. I thought I fixed this ages ago by putting the sonatype properties in gradle.properties. Is that not working for you?

@rwdalpe

This comment has been minimized.

Show comment
Hide comment
@rwdalpe

rwdalpe Nov 14, 2017

I might just be missing something, but I think that only the travis build adds the sonatype properties.

https://github.com/ndw/xmlcalabash1-gradle/blob/master/gradle.properties has nothing defined for that purpose, and .travis.yml echos values into the file before a build starts.

rwdalpe commented Nov 14, 2017

I might just be missing something, but I think that only the travis build adds the sonatype properties.

https://github.com/ndw/xmlcalabash1-gradle/blob/master/gradle.properties has nothing defined for that purpose, and .travis.yml echos values into the file before a build starts.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Mar 4, 2018

Owner

I don't believe this is true any longer. If you're still having problems, please reopen the bug.

Owner

ndw commented Mar 4, 2018

I don't believe this is true any longer. If you're still having problems, please reopen the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment