pxf:delete/@recursive="true" fails #155

Closed
alexmilowski opened this Issue May 13, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@alexmilowski

Let's start with that everything works in 1.0.16-95.

I get these errors on a simple delete of a directory:

May 12, 2014 7:18:21 PM com.xmlcalabash.util.DefaultXProcMessageListener error
SEVERE: subset-epub.xpl:30:33:Cannot delete: file does not exist
May 12, 2014 7:18:21 PM com.xmlcalabash.drivers.Main error
SEVERE: com.xmlcalabash.core.XProcException: Cannot delete: file does not exist
May 12, 2014 7:18:21 PM com.xmlcalabash.drivers.Main error
SEVERE: Underlying exception: java.io.FileNotFoundException: /Users/alex/workspace/tdo/build/Book.epub.tmp/META-INF/container.xml is not a directory

I can't recreate the error with a small test case but the test case I created fails to do anything in 1.0.17-95 or 1.0.18-95.

@alexmilowski

This comment has been minimized.

Show comment
Hide comment
@alexmilowski

alexmilowski May 13, 2014

Github stinks for attachments to issues.

Github stinks for attachments to issues.

@alexmilowski

This comment has been minimized.

Show comment
Hide comment
@alexmilowski

alexmilowski May 13, 2014

<p:declare-step xmlns:p="http://www.w3.org/ns/xproc"
    xmlns:c="http://www.w3.org/ns/xproc-step" version="1.0"
    xmlns:pxf="http://exproc.org/proposed/steps/file"
   >
   <p:import href="http://xmlcalabash.com/extension/steps/library-1.0.xpl"/>
   <pxf:delete href="tmp" recursive="true" fail-on-error="false"/> 
</p:declare-step>
<p:declare-step xmlns:p="http://www.w3.org/ns/xproc"
    xmlns:c="http://www.w3.org/ns/xproc-step" version="1.0"
    xmlns:pxf="http://exproc.org/proposed/steps/file"
   >
   <p:import href="http://xmlcalabash.com/extension/steps/library-1.0.xpl"/>
   <pxf:delete href="tmp" recursive="true" fail-on-error="false"/> 
</p:declare-step>
@alexmilowski

This comment has been minimized.

Show comment
Hide comment
@alexmilowski

alexmilowski May 13, 2014

<project basedir="." default="build-test" name="Build Test">
<target name="build-test">
<mkdir dir="tmp"/>
<mkdir dir="tmp/test"/>
<echo file="tmp/a.txt">A</echo>
<echo file="tmp/test/b.txt">B</echo>
</target>
</project>
<project basedir="." default="build-test" name="Build Test">
<target name="build-test">
<mkdir dir="tmp"/>
<mkdir dir="tmp/test"/>
<echo file="tmp/a.txt">A</echo>
<echo file="tmp/test/b.txt">B</echo>
</target>
</project>
@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw May 21, 2014

Owner

Yeah. I see where it's broken. Sigh. Some patches I wish I'd reviewed more closely...

It'll take a little longer to fix than I have just at the moment. I'll try to fix it tonight.

Owner

ndw commented May 21, 2014

Yeah. I see where it's broken. Sigh. Some patches I wish I'd reviewed more closely...

It'll take a little longer to fix than I have just at the moment. I'll try to fix it tonight.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Aug 15, 2014

Owner

I think this is fixed in the code I just pushed to the saxon95 branch

Owner

ndw commented Aug 15, 2014

I think this is fixed in the code I just pushed to the saxon95 branch

@ndw ndw added test labels Aug 18, 2014

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Aug 18, 2014

Owner

I wonder if I just un-did this change with that directory fix. Will try when I get a chance.

Owner

ndw commented Aug 18, 2014

I wonder if I just un-did this change with that directory fix. Will try when I get a chance.

@ndw ndw added fix and removed test labels Aug 19, 2014

ndw added a commit that referenced this issue Sep 13, 2014

@ndw ndw added test and removed fix labels Sep 13, 2014

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Oct 2, 2014

Owner

Fixed, I believe.

Owner

ndw commented Oct 2, 2014

Fixed, I believe.

@ndw ndw closed this Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment