New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piperack won’t use -Dcom.xmlcalabash.serial.indent=true #158

Closed
gimsieke opened this Issue Jun 1, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@gimsieke
Contributor

gimsieke commented Jun 1, 2014

Piperack 1.0.18 will respect p:serialization settings for indentation, but not said system property.
It might seem like a bad idea to specify an indentation setting for the whole server, but there is a use case…

@gimsieke

This comment has been minimized.

Show comment
Hide comment
@gimsieke

gimsieke Jun 1, 2014

Contributor

Addition 1: If you have a primary and another output port, the 'indent' serialization property (maybe other serialization props, too) of the primary port will always be used for both ports, no matter what is specified for the non-primary port.
Repro: add <p:serialization port="result2" indent="false"/> to pipe.xpl as given on http://xmlcalabash.com/docs/reference/using-piperack.html

Addition 2 (not exactly about indentation, but I don’t want to spoil your break with too many distinct bug reports, so I’m reusing this issue): if none of the ports in pipe.xsl is primary and if I post an input doc to the source port and then run the pipeline, it will tell me that there’s 1 document waiting on each port, that’s ok so far. But when I’m trying to GET any of them from …/pipelines/…/outputs/result2 or from …/pipelines/…/outputs/result, I get the following error:

Exception or error caught in server resource

java.lang.NullPointerException
at com.xmlcalabash.model.Step.getOutput(Unknown Source)
at com.xmlcalabash.model.CompoundStep.getOutput(Unknown Source)
at com.xmlcalabash.runtime.XPipeline.getSerialization(Unknown Source)
at com.xmlcalabash.piperack.BaseResource.getOutput(Unknown Source)
at com.xmlcalabash.piperack.Output.get(Unknown Source)
……

Contributor

gimsieke commented Jun 1, 2014

Addition 1: If you have a primary and another output port, the 'indent' serialization property (maybe other serialization props, too) of the primary port will always be used for both ports, no matter what is specified for the non-primary port.
Repro: add <p:serialization port="result2" indent="false"/> to pipe.xpl as given on http://xmlcalabash.com/docs/reference/using-piperack.html

Addition 2 (not exactly about indentation, but I don’t want to spoil your break with too many distinct bug reports, so I’m reusing this issue): if none of the ports in pipe.xsl is primary and if I post an input doc to the source port and then run the pipeline, it will tell me that there’s 1 document waiting on each port, that’s ok so far. But when I’m trying to GET any of them from …/pipelines/…/outputs/result2 or from …/pipelines/…/outputs/result, I get the following error:

Exception or error caught in server resource

java.lang.NullPointerException
at com.xmlcalabash.model.Step.getOutput(Unknown Source)
at com.xmlcalabash.model.CompoundStep.getOutput(Unknown Source)
at com.xmlcalabash.runtime.XPipeline.getSerialization(Unknown Source)
at com.xmlcalabash.piperack.BaseResource.getOutput(Unknown Source)
at com.xmlcalabash.piperack.Output.get(Unknown Source)
……

@ndw ndw added the verify label Aug 18, 2014

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Aug 22, 2014

Owner

Sorry for the horrible delay. I'll try to get to these soon.

Owner

ndw commented Aug 22, 2014

Sorry for the horrible delay. I'll try to get to these soon.

@ndw ndw closed this Aug 22, 2014

@ndw ndw reopened this Aug 22, 2014

ndw added a commit that referenced this issue Aug 23, 2014

Fix (part of) issue #158 by using the appropriate port serialization …
…parameters instead of always using the parameters of the default port

@ndw ndw added test and removed verify labels Aug 23, 2014

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Aug 23, 2014

Owner

Hi Gerrit,

I can't reproduce the first issue. If I start piperack with a serialization option specified in a system property, it works for me. Can you reproduce that issue?

I just fixed the second issue, where the wrong port serialization parameters were being used.

I can't reproduce the third issue.

If you can reproduce either the first or third issue, please open a new issue for each of them. It's really much easier for me to track things if there's a separate issue for each defect. Thanks

/cc @gimsieke

Owner

ndw commented Aug 23, 2014

Hi Gerrit,

I can't reproduce the first issue. If I start piperack with a serialization option specified in a system property, it works for me. Can you reproduce that issue?

I just fixed the second issue, where the wrong port serialization parameters were being used.

I can't reproduce the third issue.

If you can reproduce either the first or third issue, please open a new issue for each of them. It's really much easier for me to track things if there's a separate issue for each defect. Thanks

/cc @gimsieke

@gimsieke

This comment has been minimized.

Show comment
Hide comment
@gimsieke

gimsieke Aug 23, 2014

Contributor

I can’t reproduce the original issue, either.

Contributor

gimsieke commented Aug 23, 2014

I can’t reproduce the original issue, either.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Aug 26, 2014

Owner

I believe this is fixed in XML Calabash 1.0.19, released today.

Owner

ndw commented Aug 26, 2014

I believe this is fixed in XML Calabash 1.0.19, released today.

@ndw ndw closed this Aug 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment