Default catalog addition fails for invocation with relative -jar path (and absolute path on Windows)

[gimsieke]

Lines 222 and 226 in core/XProcConfiguration.java in the Saxon 9.7 branch should be:

catalogs.add(getClass().getResource("/catalog.xml").toString());

and

catalogs.add(getClass().getResource("/META-INF/catalog.xml").toString());

respectively.

I can create a pull request but I don’t know whether this will work. In order to make it compile, I needed to change Configuration.softwareEdition into Version.softwareEdition.

But then I could add my top-level catalog as /META-INF/catalog.xml and it would work on Cygwin with a Windows Java using both java -jar $(cygpath -ma xmlcalabash-1.1.19-97.jar) and java -jar xmlcalabash-1.1.19-97.jar. Yay!

Otherwise, it would try to load jar:file://xmlcalabash-1.1.19-97.jar!/META-INF/catalog.xml for the relative path or jar:file://C:/cygwin/home/gerrit/…/xmlcalabash-1.1.19-97.jar!/META-INF/catalog.xml for the absolute path. The first one doesn’t exist even on Linux and the second one should start with either jar:file:///C:/ or jar:file:/C:/. This string fumbling can be avoided with getClass().getResource() which will return the correct jar: URLs in any case.

[ndw]

getClass().getResource() only returns the first catalog file, not all of the catalog files, so I think I still have to do the loop. And I really don't understand your comment about Version.softwareEdition.
Can you please test #271 and tell me if it works for you?

[gimsieke]

Re Configuration.softwareEdition:

When running javac, I received errors like this one:

XProcConfiguration.java:178: error: cannot find symbol
        saxonProcessor = Configuration.softwareEdition.toLowerCase();

I could avoid them by adding import net.sf.saxon.Version; and changing Configuration.softwareEdition to Version.softwareEdition. When i look at the API docs, only Version seems to have a property called softwareEdition, not Configuration. But what do I know about Java?

[gimsieke]

I compiled the core/XProcConfiguration.java of #271, this time without a javac complaint.
After I updated the resulting classes in xmlcalabash-1.1.19-97.jar, my test case still worked, both for the absolute Windows path and for the relative path invocations. Thanks!

[ndw]

In XProcConfiguration.java in the saxon97 branch of XML Calabash, line 178 is:

saxonProcessor = Version.softwareEdition.toLowerCase();

So I think you must have had the wrong branch checked out or something.

But it sounds like my patch worked for you. I'll apply it and make a new release this evening.

[gimsieke]

Ah yes, I cloned the saxon96 branch, apparently.

[ndw]

Fixed in 1.1.20.