New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantics of assert-valid in p:validate-with-schematron #278

Closed
gimsieke opened this Issue Jul 27, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@gimsieke
Contributor

gimsieke commented Jul 27, 2018

A customer just wondered why a pipeline that uses p:validate-with-schematron behaves differently for two documents although each of them rises a Schematron error. Since we were only interested in the SVRL, I switched assert-valid to false and then both documents behaved the same. It turns out that in one of the reports, there was an svrl:failed-assert while the other one only contained an svrl:successful-report. Checking the code brought to light that you only check for failed-asserts, not for successful-reports. In my view they should be treated the same though, that is, in Schematron a successful report is a failed assertion.
In any case, we should clarify in the 3.0 spec whether the presence of an svrl:successful-report is supposed to raise the same dynamic error as svrl:failed-assert when assert-valid="true".

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Jul 27, 2018

Owner

That's a bug. I'll fix it asap.

Owner

ndw commented Jul 27, 2018

That's a bug. I'll fix it asap.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Aug 26, 2018

Owner

Fixed in 1.1.22.

Owner

ndw commented Aug 26, 2018

Fixed in 1.1.22.

@ndw ndw closed this Aug 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment