Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main xmlcalabash jar file missing #296

Closed
cmosher01 opened this issue Oct 17, 2019 · 10 comments

Comments

@cmosher01
Copy link

@cmosher01 cmosher01 commented Oct 17, 2019

As of release 1.1.28, the main xmlcalabash jar file is missing from the distribution:

$ unzip -l xmlcalabash-1.1.27-98.zip | grep '/xmlcalabash.*jar'
   953812  2019-06-02 08:04   xmlcalabash-1.1.27-98/xmlcalabash-1.1.27-98.jar
$ unzip -l xmlcalabash-1.1.28-98.zip | grep '/xmlcalabash.*jar'
$ 
@ndw

This comment has been minimized.

Copy link
Owner

@ndw ndw commented Oct 17, 2019

Uhhhmmm. How did...I'm working on it.

@ndw

This comment has been minimized.

Copy link
Owner

@ndw ndw commented Oct 17, 2019

For some reason, on travis the name of the jar file that's built by gradle is different.

@chris-mosher

This comment has been minimized.

Copy link

@chris-mosher chris-mosher commented Oct 17, 2019

I think you should make a settings.gradle file, with rootProject.name = 'xmlcalabash' in it.

@ndw

This comment has been minimized.

Copy link
Owner

@ndw ndw commented Oct 17, 2019

That's already in there.

@cmosher01

This comment has been minimized.

Copy link
Author

@cmosher01 cmosher01 commented Oct 17, 2019

I was looking at the saxon99 branch, and I don't see it:

$ git checkout saxon99
Switched to branch 'saxon99'
Your branch is up to date with 'origin/saxon99'.
$ ls
build.gradle  docs  gradle.properties  lib  README.md  resources  src  test  xpl
@cmosher01

This comment has been minimized.

Copy link
Author

@cmosher01 cmosher01 commented Oct 17, 2019

$ gradle dist
...
$ ls build/dist
calabash  calabash.bat  docs  lib  README  schemas  VERSION  xpl


$ echo "rootProject.name = 'xmlcalabash'" >settings.gradle
$ gradle dist
...
$ ls build/dist
calabash  calabash.bat  docs  lib  README  schemas  VERSION  xmlcalabash-1.1.28-99.jar  xpl
@ndw

This comment has been minimized.

Copy link
Owner

@ndw ndw commented Oct 17, 2019

Yeah. That's clearly the problem now, but it used to work and I still have a settings.gradle file in my checked out version, so I'm trying to figure out what went wrong and when (and why).

@cmosher01

This comment has been minimized.

Copy link
Author

@cmosher01 cmosher01 commented Oct 17, 2019

If you don't specify the project name in the settings.gradle file, it uses the name of the root directory, which can change from system to system, for example if you changed the directory name from xmlcalabash to xmlcalabash1 ;)

@ndw

This comment has been minimized.

Copy link
Owner

@ndw ndw commented Oct 17, 2019

Yes. I'm going to add the settings.gradle file and push 1.29.x out. What baffles me is how it worked on Travis for 1.27.x! The repo hasn't been renamed recently and the settings.gradle file was, evidently, missing.

@ndw

This comment has been minimized.

Copy link
Owner

@ndw ndw commented Oct 17, 2019

Resolved in 1.29.x, just released now. Thank you for the bug report and the help!

@ndw ndw closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.