Add javac class target version #104

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jamesrdf
Contributor

jamesrdf commented Jun 18, 2013

The target Java class binary version should be explicit in the build.xml file for repeatable builds.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Jul 25, 2013

Owner

But I assume it means that you can't build with 1.7 for example, or 1.5 (if that even still works).

What's the repeatability problem without this?

Owner

ndw commented Jul 25, 2013

But I assume it means that you can't build with 1.7 for example, or 1.5 (if that even still works).

What's the repeatability problem without this?

@jamesrdf

This comment has been minimized.

Show comment
Hide comment
@jamesrdf

jamesrdf Jul 26, 2013

Contributor

Without this, the build is dependent on the minor java version used to compile it. By using this flag the code can be compiled with javac 1.7 and used with java 1.6.

This flag does not cover all cases, if the code uses 1.7 specific API calls the compile may not notice (if compiled with 1.7) producing a runtime error. However, that (I believe) is manageable.

Contributor

jamesrdf commented Jul 26, 2013

Without this, the build is dependent on the minor java version used to compile it. By using this flag the code can be compiled with javac 1.7 and used with java 1.6.

This flag does not cover all cases, if the code uses 1.7 specific API calls the compile may not notice (if compiled with 1.7) producing a runtime error. However, that (I believe) is manageable.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Jul 26, 2013

Owner

Thanks for the explanation.

Owner

ndw commented Jul 26, 2013

Thanks for the explanation.

@ndw ndw closed this Jul 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment