Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate Maven uploads #113

Closed
wants to merge 3 commits into from
Closed

Reinstate Maven uploads #113

wants to merge 3 commits into from

Conversation

@rdeltour
Copy link
Contributor

@rdeltour rdeltour commented Aug 14, 2013

Here's an attempt to re-instate the Maven uploads. You wrote:

my attempts to introduce the Saxon version number to the artifact names were apparently unsuccessful

This PR sets the POM version to the value of the property mvn-version which in turn is based on saxon-version. It results in artifact file names like xmlcalabash-1.0.12a-94. Is that OK ?

Note that I also included a fix to the bnd config file (used for the OSGi metadata generation); it now looks at the saxon95 property to declare the correct version of the Saxon dependency.

@rdeltour
Copy link
Contributor Author

@rdeltour rdeltour commented Aug 14, 2013

I just added commit 8e68c0c to filter the hard-coded POM template with the saxon-version property to set the correct Saxon dependency version in the POM.

Note:

  • Saxon-HE 9.3 is not on Maven Central, but AFAIK Calabash no longer targets Saxon 9.3.x
  • the ant build file will need to be updated along the same lines in the saxon95 branch
ndw added a commit that referenced this pull request Aug 20, 2013
ndw added a commit that referenced this pull request Aug 20, 2013
@ndw
Copy link
Owner

@ndw ndw commented Aug 20, 2013

I think I did the staging/release dance correctly.

@ndw ndw closed this Aug 20, 2013
@rdeltour
Copy link
Contributor Author

@rdeltour rdeltour commented Aug 21, 2013

Cool, thanks!

i noticed however that the artifact on the Sonatype OSS repository but not on Maven Central so either you've not "closed" and "released" the staged artifact, or the automatic sync with Maven Central is not in place for the com.xmlcalabash group ID.

@ndw
Copy link
Owner

@ndw ndw commented Aug 21, 2013

OH FOR CRYING OUT LOUD!

I have closed it, what do I have to do to "release" it?

@rdeltour
Copy link
Contributor Author

@rdeltour rdeltour commented Aug 21, 2013

As far as I remember once you've closed it you need to go back to the "staging repositories" UI and press the "release" button. I'm not sure why this 2-steps process is required.

More details in this guide.

@ndw
Copy link
Owner

@ndw ndw commented Aug 21, 2013

Ok. I think I released it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.