New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use system property 'file.encoding' (fallback: UTF-8) for files #201

Closed
wants to merge 1 commit into
base: saxon95
from

Conversation

Projects
None yet
2 participants
@gimsieke
Contributor

gimsieke commented Feb 28, 2015

I had to use p:http-request to read local non-XML files. (Is there another step for doing this?)
The files contained UTF-8 encoded snippets of XHTML5 files, no encoding declaration whatsoever in them. I added the validator.nu jar to be able to parse them as text/html. They were read as if they had an ISO-8859-1 charset.
Since I specify -Dfile-encoding=UTF-8 in my front-end script for calabash anyway, I thought that calabash might want to make use of this system property, if set. If it isn’t set, I think it’s a sensible choice in 2015 to use UTF-8 as default.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw May 5, 2015

Owner

Right. Fixed for the next release.

Owner

ndw commented May 5, 2015

Right. Fixed for the next release.

ndw added a commit that referenced this pull request May 14, 2015

ndw added a commit that referenced this pull request May 14, 2015

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Oct 23, 2015

Owner

I think this is fixed.

Owner

ndw commented Oct 23, 2015

I think this is fixed.

@ndw ndw closed this Oct 23, 2015

gimsieke pushed a commit to transpect/use-css-decorator-classes that referenced this pull request Nov 20, 2015

gimsieke added a commit to transpect/use-css-decorator-classes that referenced this pull request Nov 20, 2015

gimsieke added a commit to transpect/use-css-decorator-classes that referenced this pull request Nov 20, 2015

gimsieke added a commit to transpect/html2hub that referenced this pull request Mar 3, 2016

gimsieke added a commit to transpect/html2hub that referenced this pull request Mar 3, 2016

gimsieke added a commit to transpect/html2hub that referenced this pull request Mar 3, 2016

gimsieke added a commit to transpect/hub2dbk that referenced this pull request Apr 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment