make getCompressedSize and getSize from ZipEntry working again #229
Conversation
Zip entry size = −1 for compressed entries Switched from ZipInputStream to ZipFile to make it work.
Can you tell me more about what bug this fixes? I created a zip file and ran unzip on it, I got:
It looks like size and compressed-size are working... |
If you're using this gist https://gist.github.com/gimsieke/209341895897cad40611 the size and compressed size aren't working. |
Oh, I see. If the inputs are being streamed then there's no way to know the size. Having to write them to disk seems like potentially a lot of overhead. I wonder if this needs to be optional at the very least. |
ndw
added a commit
that referenced
this pull request
Apr 14, 2017
ndw
added a commit
that referenced
this pull request
Apr 14, 2017
ndw
added a commit
that referenced
this pull request
Apr 14, 2017
Fixed, I believe. Sorry for how long it took. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ZipEntry size/compressedSize = −1 for compressed entries
Switched from ZipInputStream to ZipFile to make it work.