Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make getCompressedSize and getSize from ZipEntry working again #229

Closed
wants to merge 1 commit into from

Conversation

@OSwoboda
Copy link

@OSwoboda OSwoboda commented Oct 17, 2015

ZipEntry size/compressedSize = −1 for compressed entries

Switched from ZipInputStream to ZipFile to make it work.

Zip entry size = −1 for compressed entries

Switched from ZipInputStream to ZipFile to make it work.
@ndw
Copy link
Owner

@ndw ndw commented Oct 23, 2015

Can you tell me more about what bug this fixes? I created a zip file and ran unzip on it, I got:

 <c:file compressed-size="4446"
           size="14844"
           name="build.gradle"
           date="2015-10-23T12:42:38.000+09:00"/>

It looks like size and compressed-size are working...

@OSwoboda
Copy link
Author

@OSwoboda OSwoboda commented Oct 26, 2015

If you're using this gist https://gist.github.com/gimsieke/209341895897cad40611 the size and compressed size aren't working.

@ndw
Copy link
Owner

@ndw ndw commented Oct 27, 2015

Oh, I see. If the inputs are being streamed then there's no way to know the size.

Having to write them to disk seems like potentially a lot of overhead. I wonder if this needs to be optional at the very least.

ndw added a commit that referenced this pull request Apr 14, 2017
ndw added a commit that referenced this pull request Apr 14, 2017
ndw added a commit that referenced this pull request Apr 14, 2017
@ndw
Copy link
Owner

@ndw ndw commented Apr 14, 2017

Fixed, I believe. Sorry for how long it took.

@ndw ndw closed this Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants