Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the generation of the Maven pom.xml files #236

Closed
wants to merge 2 commits into from

Conversation

@adamretter
Copy link

adamretter commented Mar 22, 2016

The published Maven pom.xml file for version 1.1.9-96 is missing a required repository to be able to use the artifact with a Maven project.

i.e. https://repo1.maven.org/maven2/com/xmlcalabash/xmlcalabash/1.1.9-96/xmlcalabash-1.1.9-96.pom is missing the section:

<repositories>
    <repository>
        <id>restlet</id>
        <url>http://maven.restlet.org</url>
    </repository>
</repositories>

which is required to resolve it's dependency on: org.restlet.jee:*:2.2.2.

This PR ensures that:

  1. The repository is added to the pom.xml before publishing.
  2. The install task also generates the correct pom.xml.
@ndw
Copy link
Owner

ndw commented Aug 14, 2016

I've merged this one in "by hand" because it seemed to have been half completed through some other fix.

@ndw ndw closed this Aug 14, 2016
ndw added a commit that referenced this pull request Aug 14, 2016
ndw added a commit that referenced this pull request Aug 14, 2016
@ndw ndw reopened this Aug 14, 2016
@ndw
Copy link
Owner

ndw commented Aug 14, 2016

@adamretter with these changes, 'gradle uploadArchives' fails. It claims there's some sort of cycle in the component graph.

Before I rip it all out and put it back the way it was...can you see what's wrong?

@adamretter
Copy link
Author

adamretter commented Aug 16, 2016

@ndw I am afraid that I worked on this quite some time ago. I don't know or use Gradle, so each time I work with it, I have to go and learn it again. So er... nope I have no idea why uploadArchives would fail, sorry.

@ndw
Copy link
Owner

ndw commented Aug 16, 2016

Please accept my apologies, Adam. The problem was something to do with gradle 2.10. Per some digging in Google, upgrading gradle fixed it.

@ndw ndw closed this Aug 16, 2016
@adamretter
Copy link
Author

adamretter commented Aug 16, 2016

@ndw No worries buddy.

@adamretter adamretter deleted the adamretter:saxon96-maven-fixes branch Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.