A lot of fixes and improvements, see the single commit messages for more information #99

Closed
wants to merge 79 commits into
from

Conversation

Projects
None yet
2 participants
@Vampire

Vampire commented May 3, 2013

No description provided.

Vampire added some commits Mar 8, 2013

do not skip ant task execution if input and output have the same last…
… modified date, as this most likely means the input and output files are identical and thus the timestamps are not good up-to-date check
also check whether libraries and pipeline are specified together and …
…give a more meaningful error message than 'Unparseable option'
output a linebreak before the usage message to separate it from the e…
…rror message and make that one more observable
refactor Main driver and ParseArgs to have a separate data holder for…
… the user arguments and to make the work method in Main driver usable for other drivers
do not require a prefix binding to be defined before its usage, but c…
…heck the binding availability after all parsing is done, this will also be useful for the ant task where it is not predictable in which order stuff is set
make the port specification for -i and -d options optional and bind t…
…o the primary non-parameter input port if not given
allow usage of streams for output to make it possible to use any writ…
…able Ant resource from CalabashTask driver, not only FileResources
allow usage of streams for pipeline to make it possible to use any re…
…adable Ant resource from CalabashTask driver, not only FileResources
interpret input and pipeline resources' lastModified date as Long.MAX…
…_VALUE if it couldn't be determined and thus execute the task

Vampire added some commits Apr 22, 2013

check again for option and parameter uniqueness in given parameters a…
…s you can give the same one with different prefixes or once with prefix and once in Clark notation otherwise
use URI.create() instead of new URI(), as this should be used for kno…
…wn URI that cannot normally give an URISyntaxException
correctly handle a return value of "null" from URLConnection.getConte…
…ntType() and thus do not depend on the Sun / Oracle Implementation which returns "content/unknown" instead of "null"
make it possible to specify the content type for data inputs from the…
… command line and Ant task instead of the hard-coded text/plain and thus correctly Base64-encode non-text data input and use user-given content type preferred over content type that is determined from the content or name

ndw added a commit that referenced this pull request Jul 26, 2013

ndw added a commit that referenced this pull request Jul 26, 2013

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Jul 26, 2013

Owner

Wow. That was a lot of work, thanks Vampire!

There was one bug in your patch, in the handling of content types, so I didn't apply exactly what you suggested. Thanks for all the doc fixes and the work on the Ant task.

Owner

ndw commented Jul 26, 2013

Wow. That was a lot of work, thanks Vampire!

There was one bug in your patch, in the handling of content types, so I didn't apply exactly what you suggested. Thanks for all the doc fixes and the work on the Ant task.

@ndw ndw closed this Jul 26, 2013

ndw added a commit that referenced this pull request Jul 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment