Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlresolver.properties should not be packaged in xmlresolver jar file #21

Closed
cmarchand opened this Issue Mar 3, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@cmarchand
Copy link

cmarchand commented Mar 3, 2019

Hi Norm,

When using xmlresolver in a maven project, I'm able to define a xmlresolver.properties in src/main/resources to package it in my application.
But when Maven constructs the classpath, there is no guarantee that my xmlresolver.properties is before xmlresolver's one, and so, there is no guarantee I'll be able to override default configuration.

xmlresolver should keep its xmlresolver.properties in another classpath entry than /xmlresolver.properties, and load it only if there is no xmlresolver.properties defined in classpath.

@ndw

This comment has been minimized.

Copy link
Owner

ndw commented Mar 3, 2019

And you couldn't have mentioned this a week ago because why? 😄

Yes, I think you're right. 1.0.1 coming up soonish.

@cmarchand

This comment has been minimized.

Copy link
Author

cmarchand commented Mar 3, 2019

I knew you'ld answer this... But I just felt on this problem this morning...
Sorry about that,
Christophe

@cmarchand

This comment has been minimized.

Copy link
Author

cmarchand commented Mar 3, 2019

But your new documentation is pretty beautiful !

@ndw

This comment has been minimized.

Copy link
Owner

ndw commented Mar 5, 2019

I concur that simply removing the xmlresolver.properties file is all that is necessary. The default values for all of the properties named in that file were the same as the values in that file.

Could you please sanity check #22 for me?

@ndw ndw closed this in #22 Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.