Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-88040-personal-menu #15

Open
wants to merge 5 commits into
base: master
from
Open

LPS-88040-personal-menu #15

wants to merge 5 commits into from

Conversation

@nealrobbins
Copy link
Owner

nealrobbins commented May 24, 2019

No description provided.

`product.navigation.personal.menu.entry.order` property determines the order of
entries within each section. Note that sections are not labelled; all you have
to do to create a new section is assign the `group` property a value other than
those for the four default sections (100, 200, 300, and 400).

This comment has been minimized.

Copy link
@pei-jung

pei-jung Jul 23, 2019

Include a screenshot here to illustrate what a section is in the personal menu.
Screen Shot 2019-07-23 at 2 52 26 PM

This comment has been minimized.

Copy link
@nealrobbins
}
```
`getPortletURL` returns the URL for the portlet you want to access with the

This comment has been minimized.

Copy link
@pei-jung

pei-jung Jul 23, 2019

getPortletURL returns the URL for the portlet or page you want to access with the entry

This comment has been minimized.

Copy link
@nealrobbins
`isActive`: indicate whether the entry is currently active.
`isShow`: write logic to determine under what circumstances the entry is displayed.

This comment has been minimized.

Copy link
@pei-jung

pei-jung Jul 23, 2019

Add a note for BasePersonalMenuEntry:

You can simplify your implementation by extending a base class that already implements the PersonalMenuEntry interface. If your entry directs to a specific portlet, the recommended way to do this is by extending the BasePersonalMenuEntry class. See MyAccountPersonalMenuEntry as an example.

This comment has been minimized.

Copy link
@nealrobbins
@mwilliams2014

This comment has been minimized.

Copy link

mwilliams2014 commented Jul 24, 2019

Thanks for the updates @pei-jung ! I'll make sure to include them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.