New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Run tests on pull requests #890
Conversation
222f837
to
d369760
Compare
42ee552
to
5287403
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but added some questions to confirm workflow trigger and cancel behavior 😃
Also I have intentionally left out eslint and TypeScript checks because there are lots of errors 😅 We can add those in once we get them to a stable state. |
Cool, opinions on fuzz tests in this workflow? |
@esaminu Do we have fuzz tests already in place for |
I see a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
This PR adds a new Github Action to run tests on submitted pull requests.