Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run tests on pull requests #890

Merged
merged 4 commits into from Jul 18, 2022
Merged

ci: Run tests on pull requests #890

merged 4 commits into from Jul 18, 2022

Conversation

morgsmccauley
Copy link
Collaborator

@morgsmccauley morgsmccauley commented Jul 12, 2022

This PR adds a new Github Action to run tests on submitted pull requests.

@morgsmccauley morgsmccauley force-pushed the pr-builds branch 3 times, most recently from 222f837 to d369760 Compare July 13, 2022 21:37
@morgsmccauley morgsmccauley changed the title PR builds WIP ci: Run tests on pull requests Jul 13, 2022
@morgsmccauley morgsmccauley force-pushed the pr-builds branch 9 times, most recently from 42ee552 to 5287403 Compare July 13, 2022 22:52
@morgsmccauley morgsmccauley marked this pull request as ready for review July 14, 2022 22:10
Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but added some questions to confirm workflow trigger and cancel behavior 😃

.github/workflows/pull-request.yml Show resolved Hide resolved
.github/workflows/pull-request.yml Show resolved Hide resolved
@morgsmccauley
Copy link
Collaborator Author

Also I have intentionally left out eslint and TypeScript checks because there are lots of errors 😅 We can add those in once we get them to a stable state.

@esaminu
Copy link
Collaborator

esaminu commented Jul 18, 2022

Also I have intentionally left out eslint and TypeScript checks because there are lots of errors 😅 We can add those in once we get them to a stable state.

Cool, opinions on fuzz tests in this workflow?

@morgsmccauley
Copy link
Collaborator Author

Cool, opinions on fuzz tests in this workflow?

@esaminu Do we have fuzz tests already in place for near-api-js?

@esaminu
Copy link
Collaborator

esaminu commented Jul 18, 2022

I see a fuzz script in our root package.json but I'm not sure it works, approving to unblock but lmk what you discover 😄

Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@morgsmccauley morgsmccauley merged commit 629dc30 into master Jul 18, 2022
@morgsmccauley morgsmccauley deleted the pr-builds branch July 18, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants