Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

refactor: create entities component for groups and users #37

Merged
merged 32 commits into from Jan 11, 2021
Merged

refactor: create entities component for groups and users #37

merged 32 commits into from Jan 11, 2021

Conversation

RudyRed
Copy link
Contributor

@RudyRed RudyRed commented Jan 5, 2021 •
edited

fixes issue #23

simoneb
simoneb suggested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some work to do on the abstraction, while extracting the component you missed some details which are different between users and groups

packages/brokeneck-react/src/components/Entities.js Outdated Show resolved Hide resolved
packages/brokeneck-react/src/components/Entities.js Outdated Show resolved Hide resolved
packages/brokeneck-react/src/components/Groups.js Show resolved Hide resolved
Mathieu Davy and others added 19 commits January 6, 2021 13:17
feat: header styles and theming
00b6777
feat: update section headers and actions
b5a51da
feat: redesign tables and fields
17bada9
feat: update create dialogs
c958cf1
feat: adding row click navigation
4619c32
build: add material ui icons dependency
232a9bd
build: fix build deps
1e0695d
feat: use theme switcher context instead of useTheme hook
5f56e8c
feat: useTheme within useFields
2486b50 
Much neater!
feat: remove roboto font load
df84949
fix: removing inline styles on Tab icons
b2e4d03
fix: revert page options
3ccdcd9
fix: refactor theme overrides
0bc8732
fix: default theme colours were broken after previous commit
d8dd694
fix: add theme overrides for integration with pages that have their o…
52206a1 
…wn styles
refactor: create entity component
a6c2182
fix: entity specifix create dialog box
d6e8ab4
style: arrange props alphabetically
282c00d
fix: missing can search group provider check
5e03a80
@RudyRed RudyRed marked this pull request as ready for review January 6, 2021 15:20
Mathieu Davy and others added 6 commits January 6, 2021 17:01
fix: fix icon component names
e6db992
fix: useMemo for theme provider value
e54b8cd
fix: using icons map for provider
1ecbbb2 
This will avoid showing the Cognito icon if
the server returns a provider unknown to the front-end.
fix: update all icons
e16634a
fix: entities rows interaction
153a42c
Merge branch 'new-design' of https://github.com/nearform/brokeneck in…
0bfc62e 
…to refactor/remove-duplication-entity-components
Mathieu Davy and others added 5 commits January 7, 2021 11:28
Merge branch 'master' into refactor/remove-duplication-entity-components
8bef9e0 
# Conflicts:
#	packages/brokeneck-html/public/index.html
#	packages/brokeneck-react/src/components/Groups.js
#	packages/brokeneck-react/src/components/Navigation.js
#	packages/brokeneck-react/src/components/Provider.js
#	packages/brokeneck-react/src/components/Users.js
#	packages/brokeneck-react/src/hooks/useFields.js
#	packages/brokeneck-react/src/theme.js
Merge branch 'master' of https://github.com/nearform/brokeneck into r…
aee9841 
…efactor/remove-duplication-entity-components
Merge branch 'refactor/remove-duplication-entity-components' of https…
bf11616 
…://github.com/nearform/brokeneck into refactor/remove-duplication-entity-components
style: remove commented code
e69f2e9
style: quote styling
c15b96c
@RudyRed RudyRed requested a review from simoneb January 8, 2021 15:22
simoneb
simoneb approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@simoneb simoneb merged commit a93a351 into master Jan 11, 2021
@simoneb simoneb deleted the refactor/remove-duplication-entity-components branch January 11, 2021 13:29
@simoneb simoneb mentioned this pull request Jan 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RudyRed @simoneb