Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cjs, es & umd bundles for graphql-hooks-memcache #109

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@jackdclark
Copy link
Member

jackdclark commented Mar 7, 2019

What does this PR do?

  • Creates a shared rollup config at the root
  • Moves rollup & related dependencies to root
  • Adds a rollup config, build & prepublish steps for graphql-hooks-memcache

Related issues

Closes #95

Checklist

  • I have checked the contributing document
  • I have added or updated any relevant documentation
  • I have added or updated any relevant tests

@jackdclark jackdclark requested review from bmullan91 and Joezo Mar 7, 2019

"files": [
"dist",
"es",
"lib"

This comment has been minimized.

Copy link
@Joezo

Joezo Mar 7, 2019

Collaborator

I think we should publish the src folder to npm too. It can be useful to devs when debugging. Thoughts? @jackdclark @bmullan91

This comment has been minimized.

Copy link
@jackdclark

jackdclark Mar 7, 2019

Author Member

Yep, can do 👍

This comment has been minimized.

Copy link
@bmullan91

bmullan91 Mar 7, 2019

Member

Makes sense 👍

@bmullan91
Copy link
Member

bmullan91 left a comment

LGTM 👍

"files": [
"dist",
"es",
"lib"

This comment has been minimized.

Copy link
@bmullan91

bmullan91 Mar 7, 2019

Member

Makes sense 👍

@jackdclark jackdclark referenced this pull request Mar 7, 2019

Merged

chore: add example SSR app built using Fastify #110

3 of 3 tasks complete

@jackdclark jackdclark merged commit 9dd1004 into master Mar 7, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 98.592%
Details

@jackdclark jackdclark deleted the feat/rollup-memcache branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.