Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add example SSR app built using Fastify #110

Merged
merged 10 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@Joezo
Copy link
Collaborator

commented Mar 7, 2019

What does this PR do?

  • Adds an example application that @bmullan91 had been using for local dev. It's very simple but showcases the different functional features nicely and will provide a good base for local development.

  • Uses lerna's --hoist option so that multiple packages use the same copy of react/react-dom

  • Simplifies the eslint and prettier setup.

Related issues

closes #69

Checklist

  • I have checked the contributing document
  • I have added or updated any relevant documentation
  • I have added or updated any relevant tests

@Joezo Joezo requested review from jackdclark and bmullan91 Mar 7, 2019

@Joezo Joezo changed the title Add example SSR app built using Fastify chore: add example SSR app built using Fastify Mar 7, 2019

@bmullan91
Copy link
Member

left a comment

Only a few small things 👍 Thanks for this @Joezo

Show resolved Hide resolved README.md
Show resolved Hide resolved examples/fastify-ssr/src/app/AppShell.js Outdated
Show resolved Hide resolved examples/fastify-ssr/src/app/pages/ArticlePage.js Outdated
Show resolved Hide resolved examples/fastify-ssr/src/app/pages/PaginationPage.js Outdated
Show resolved Hide resolved examples/fastify-ssr/src/app/useReRenderCounter.js Outdated
Show resolved Hide resolved examples/fastify-ssr/src/server/graphql/resolvers.js
Show resolved Hide resolved examples/fastify-ssr/src/server/index.js Outdated
@jackdclark
Copy link
Member

left a comment

Nice work @Joezo & @bmullan91

Show resolved Hide resolved .eslintignore
Show resolved Hide resolved examples/fastify-ssr/src/app/pages/HomePage.js Outdated
Show resolved Hide resolved packages/graphql-hooks/package.json Outdated
Show resolved Hide resolved examples/fastify-ssr/README.md Outdated

@Joezo Joezo force-pushed the example-app branch from b1ec693 to f6a0358 Mar 7, 2019

@jackdclark
Copy link
Member

left a comment

I'm sure we can make this look nicer, but it's a good foundation for local dev 👍

Download the example:

```bash
curl https://codeload.github.com/nearform/graphql-hooks/tar.gz/master | tar -xz --strip=2 graphql-hooks-master/examples/fastify-ssr

This comment has been minimized.

Copy link
@jackdclark

jackdclark Mar 7, 2019

Member

Worth mentioning that it can just be run from the examples/ dir if you already have graphql-hooks locally?

We should update CONTRIBUTING.md to these steps in a getting started section as @jh3y mentioned in #69 too. Not a blocker for this PR, can be followed up.

@Joezo

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 7, 2019

I'm sure we can make this look nicer, but it's a good foundation for local dev 👍

@jackdclark no it's beautiful as it is

@Joezo Joezo force-pushed the example-app branch from 0d72c7a to 597a141 Mar 7, 2019

@Joezo Joezo dismissed stale reviews from jackdclark and bmullan91 via d51b302 Mar 7, 2019

@Joezo Joezo merged commit 1cc8854 into master Mar 7, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 98.592%
Details

@Joezo Joezo deleted the example-app branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.