Match package.json node engines to the docs #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Aug 4, 2018
package.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "repository": "nearform/node-clinic", | |||
| "version": "1.0.2", | |||
| "engines": { | |||
| "node": "^9.4.0 || ^8.9.4" | |||
| "node": "^10.0.0 || ^8.9.4" | |||
There was a problem hiding this comment.
Thanks for the contribution can you keep the 9.4.0 part and just add the 10.0.0?
Signed-off-by: Jonathan Cremin <jonathan@crem.in>
|
@mcollina I'm using yarn. I've actually just notice that there are some dependencies (at least |
BridgeAR
approved these changes
Aug 7, 2018
|
Thanks!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It refuses to install against node 10.8.0 due to the spec in
package.json. After adjusting node engines the tests are still passing.