Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download dev keys with project + test #118

Merged
merged 6 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@janedegtiareva
Copy link
Member

commented Apr 17, 2019

No description provided.

Show resolved Hide resolved src/utils/download.ts Outdated
Show resolved Hide resolved src/utils/download.ts Outdated
Show resolved Hide resolved src/utils/download.ts Outdated
Show resolved Hide resolved src/utils/download.ts Outdated
const contractName = `studio-${uri}`;
const keyPair = await app.state.keyStore.getKey(contractName);
if (keyPair) {
const networkId = "devnet"; // TODO: query network id from node

This comment has been minimized.

Copy link
@vgrichina

vgrichina Apr 17, 2019

Member

Looks like networkId should be in keyStore though judging from tests.

This comment has been minimized.

Copy link
@janedegtiareva

janedegtiareva Apr 29, 2019

Author Member

Let's do a pass through everything later when we can actually get a real network id. I don't want to polish half baked code since things may change anyways.

@@ -30,6 +31,7 @@ export async function downloadProject(project: Project, uri?: string) {
}
const queue: Array<{filePrefix: string; file: File}> = [];
project.mapEachFile((f: File) => queue.push({filePrefix: "", file: f}));
await addDevKey(queue, uri);

This comment has been minimized.

Copy link
@vgrichina

vgrichina Apr 17, 2019

Member

I think it's better to do this as:

queue.push(await getDevKey(uri));

Makes for easier to test and more flexible method (doesn't force to use specific container type).

This comment has been minimized.

Copy link
@janedegtiareva

janedegtiareva Apr 29, 2019

Author Member

getDevKey may return null though

@janedegtiareva janedegtiareva changed the title download dev kes with project + test download dev keys with project + test Apr 29, 2019

@janedegtiareva janedegtiareva merged commit ae12e52 into master Apr 30, 2019

1 check failed

ci/gitlab/j-downloadkey Pipeline failed on GitLab
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.