Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding merkle proof to prev chunk header #1353

Merged
merged 14 commits into from Oct 1, 2019

Conversation

@Kouprin
Copy link
Collaborator

commented Sep 26, 2019

Fixes #1348.

Kouprin added 5 commits Sep 26, 2019
ISSUE
===
#1348

TEST PLAN
===
- test_catchup_random_single_part_sync
- test_catchup_random_single_part_sync_non_zero_amounts
- test_catchup_random_single_part_sync_height_6
- test_catchup_receipts_sync_third_epoch
- CI tests
- make sure the size of incoming receipts is always a diff between
BlockIndices of sync height and prev chunk
- extence ShardProof with to_shard_id field
- store proofs for empty receipts
- save the number of included chunks in block header
- prove that incoming receipts are correct on all heights
- panic while invalid last_chunk_height_included in getting incoming
receipts
- reasonable timeout in cross_shard_tx test
@Kouprin Kouprin force-pushed the T1348 branch from 6e1566c to 861755b Sep 27, 2019
@coqbot coqbot removed the needs: rebase label Sep 27, 2019
chain/chain/src/chain.rs Outdated Show resolved Hide resolved
chain/chain/src/chain.rs Outdated Show resolved Hide resolved
updates
- block skipping idea included into shard state proving
- ShardState struct
- enumeration and comments for proving activities under p. 5
- Dirichlet's -> Pigeonhole (for non-Russians)
chain/chain/src/chain.rs Outdated Show resolved Hide resolved
chain/chain/src/types.rs Outdated Show resolved Hide resolved
@Kouprin Kouprin changed the title Adding merkle proof to prev chunk header (#1348) Adding merkle proof to prev chunk header Sep 29, 2019
chain/chain/src/chain.rs Outdated Show resolved Hide resolved
chain/chain/src/chain.rs Outdated Show resolved Hide resolved
core/primitives/src/block.rs Show resolved Hide resolved
Kouprin added 2 commits Sep 30, 2019
minors
- check_block_validity
- moving some calculation outside the loop
- removed hash check
- assert -> byzantine_assert
Copy link
Member

left a comment

Approving, but don't forget to add the check that chunks_included is computed correctly when receiving a block

Kouprin added 2 commits Oct 1, 2019
chain/chain/src/types.rs Outdated Show resolved Hide resolved
chain/chain/src/store.rs Outdated Show resolved Hide resolved
chain/chain/src/chain.rs Outdated Show resolved Hide resolved
Copy link
Member

left a comment

Approved with few changes.

chain/chain/src/chain.rs Outdated Show resolved Hide resolved
Kouprin added 2 commits Oct 1, 2019
@Kouprin Kouprin merged commit 1bb5116 into staging Oct 1, 2019
1 check passed
1 check passed
gitlab-ci
Details
@Kouprin Kouprin deleted the T1348 branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.