Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced `chunk` API #1524

Merged
merged 2 commits into from Oct 23, 2019

Conversation

@frol
Copy link
Member

frol commented Oct 22, 2019

I could not make the new test case, which requests a chunk by block height (0) and shard id (0), working:

Chunk Missing: ChunkHash(`CiADPKxqY5XoSAQAkLjKohFWj9cK3tBrUVKqaEkCpU4v`)

Other than that, the implementation is working fine.

REMINDER: Update the docs with the information about the new API.

@frol frol requested a review from ilblackdragon Oct 22, 2019
@frol frol requested a review from SkidanovAlex as a code owner Oct 22, 2019
@bowenwang1996

This comment has been minimized.

Copy link
Member

bowenwang1996 commented Oct 22, 2019

I suspect it's because you pass false to start_all and thus the node is not a validator and does not have the full chunk. Also, for your purposes, I suggest you test with real runtime instead of KeyValueRuntime.

@frol

This comment has been minimized.

Copy link
Member Author

frol commented Oct 22, 2019

@bowenwang1996 I have tried to pass true to start_all, but it did not help. I have no idea what KeyValueRuntime is let alone how to setup "real runtime" 😕

@frol frol force-pushed the feature/chunks-rpc branch from b955614 to 0746d77 Oct 22, 2019
@frol frol requested review from evgenykuzyakov and nearmax as code owners Oct 22, 2019
@frol frol force-pushed the feature/chunks-rpc branch from 0746d77 to 00ae9ee Oct 22, 2019
@frol frol force-pushed the feature/chunks-rpc branch from 00ae9ee to b752c41 Oct 22, 2019
@ilblackdragon ilblackdragon merged commit 0117e6a into staging Oct 23, 2019
1 check passed
1 check passed
gitlab-ci
Details
@ilblackdragon ilblackdragon deleted the feature/chunks-rpc branch Oct 23, 2019
frol added a commit that referenced this pull request Oct 23, 2019
* Introduced `chunk` API

* Saving genesis chunks to make consistent output from chunks RPC
@frol frol referenced this pull request Oct 23, 2019
ilblackdragon added a commit that referenced this pull request Oct 24, 2019
* Introduced `chunk` API

* Saving genesis chunks to make consistent output from chunks RPC
bowenwang1996 added a commit that referenced this pull request Oct 30, 2019
* Dont panic for check balance (#1493)

* Introduce BalanceMismatch error
* Merge branch 'staging' of github.com:nearprotocol/nearcore into dont-panic-for-check-balance
* Merge branch 'staging' of github.com:nearprotocol/nearcore into dont-panic-for-check-balance
* Merge bug
* Merge branch 'staging' into dont-panic-for-check-balance
* Merge refs/heads/staging into dont-panic-for-check-balance
* Merge refs/heads/staging into dont-panic-for-check-balance
* Merge refs/heads/staging into dont-panic-for-check-balance
* Merge branch 'staging' of github.com:nearprotocol/nearcore into dont-panic-for-check-balance
* Merge branch 'dont-panic-for-check-balance' of github.com:nearprotocol/nearcore into dont-panic-for-check-balance

* Merge master into staging (#1511)

* Give more money to test.near (#1467)

* Give more money to test.near

* Bump version

* Reset state and bump version (#1499)

* Bump version for Borsh (#1502)

* Fix boot node in start_testnet.py (#1505)

* Reduce total supply and adjust parameters (#1508)

* Update dependency to avoid vulnerabilities (#1509)

* Update dependency to avoid vulnerabilities

* Remove serde_cbor

* pytest for remote node (#1437)

* gcloud lib and init/start cluster
* Merge branch 'staging' into pytest-remote
* a few fixes
* almost done
* a few more fix
* Merge branch 'staging' into pytest-remote
* more fix
* more tests
* more fix and tests
* Merge branch 'staging' into pytest-remote
* Merge branch 'staging' into pytest-remote
* Merge refs/heads/staging into pytest-remote
* Merge refs/heads/staging into pytest-remote
* Merge refs/heads/staging into pytest-remote
* Merge refs/heads/staging into pytest-remote
* Merge refs/heads/staging into pytest-remote
* Merge refs/heads/staging into pytest-remote
* Merge refs/heads/staging into pytest-remote
* Merge branch 'staging' into pytest-remote
* Merge branch 'staging' into pytest-remote
* add requirements.txt
* a few fixes
* remote version of block_production works
* Merge branch 'pytest-remote' of github.com:nearprotocol/nearcore into pytest-remote
* Merge branch 'staging' into pytest-remote
* update requirements.txt

* Remove some unnecessary unsafe code (#1512)

* Remove some unnecessary unsafe code
* Merge refs/heads/staging into remove-unsafe-code
* Merge refs/heads/staging into remove-unsafe-code

* Chaos Monkey now messes up with network (#1514)

* Chaos Monkey now messes up with network

* Fixing a typo

* Adding missing shell command

* Marking `local_network` monkey as existing

* Adding one of the new tests that was previously missing

* Handle head method for status check (#1513)

* fix head status check
* Merge branch 'staging' into handle-head-method
* Merge refs/heads/staging into handle-head-method
* Merge refs/heads/staging into handle-head-method

* recover system coredump by Misha for minimize docker image (#1528)

* recover system coredump by Misha for minimize docker image

* Move rewards to runtime (#1497)

* Move validator rewards to runtime
* Merge branch 'staging' of github.com:nearprotocol/nearcore into move-rewards-to-runtime
* Merge branch 'staging' of github.com:nearprotocol/nearcore into move-rewards-to-runtime
* Update runtime/runtime/src/lib.rs

Co-Authored-By: Maksym Zavershynskyi <35039879+nearmax@users.noreply.github.com>
* Merge branch 'staging' of github.com:nearprotocol/nearcore into move-rewards-to-runtime
* Merge branch 'move-rewards-to-runtime' of github.com:nearprotocol/nearcore into move-rewards-to-runtime
* Merge branch 'staging' into move-rewards-to-runtime
* Merge refs/heads/staging into move-rewards-to-runtime

* Fix a dependency (#1527)

* Fix a dependency

eth-secp256k1 got renamed to parity-secp256k1
* Merge refs/heads/staging into fix_build

* update rust-toolchain (#1529)

* update rust-toolchain

* Fix some warnings (#1530)

* Fix some warnings
* More warnings

* Introduced `chunk` API (#1524)

* Introduced `chunk` API

* Saving genesis chunks to make consistent output from chunks RPC

* Bump near-vm-* to 0.3.1 (#1541)

* Nit
* Bump to 0.3.1
* Nit

* working coredump for docker (#1531)

* working coredump for docker
* Merge branch 'staging' into docker-coredump
* Merge refs/heads/staging into docker-coredump

* Update dependencies (#1532)

* Update dependencies

* Merge master into staging (#1534)

* Give more money to test.near (#1467)

* Give more money to test.near

* Bump version

* Reset state and bump version (#1499)

* Bump version for Borsh (#1502)

* Fix boot node in start_testnet.py (#1505)

* Reduce total supply and adjust parameters (#1508)

* Remove all warnings (#1516)

* Add more bootnodes (#1525)

* Genesis csv to Genesis json tool + key generator (#1462)

* WIP
* Code to read token holders from the file
* Minimal code that reads genesis from csv and converts it to json
* Tool for generating key pairs
* Make csv-parser a runnable binary
* Merge
* Merge branch 'staging' into genesis-mainnet
* Merge
* Merge branch 'genesis-mainnet' of https://github.com/nearprotocol/nearcore into genesis-mainnet
* Merge branch 'staging' into genesis-mainnet
* Merge branch 'staging' into genesis-mainnet
* Nit
* Merge branch 'genesis-mainnet' of https://github.com/nearprotocol/nearcore into genesis-mainnet
* Merge branch 'staging' into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet
* Merge refs/heads/staging into genesis-mainnet

* Rpc transaction routing (#1544)

* Rpc transaction routing
* Transaction status routing
* Merge branch 'staging' into rpc-tx-routing
* Revert changes to runtime
* Fix test
* A python test for rpc tx forwarding
* fix pytest
* use SizedCache
* Add RequestRouted
Address comments

* Fix keypair generation problem when directory does not exist (#1556)

* Fix some issues related to genesis and running nodes (#1557)

* Do not always override bootnodes
* Add genesis time to Row
* bump rpc polling timeout to 10s

* toolchain set to nightly-2019-10-04 (#1539)

* Revert profile-overrides syntax after toolchain downgrade (#1558)

* Chaos Monkey now restarts nodes (#1554)

Two new modes in chaos monkey:
- `node_restart` ocasionally restarts one of the nodes that are initially running (but always just one)
- `node_set` maintains an extra set of nodes (which are initially shut down), and prediodically restarts them arbitrarily, ocasionally also wiping out their data folders.

* fix a few queries which was work for only one node by aggregate (#1563)

* fix a few queries which was work for only one node by aggregate
* Merge branch 'staging' into fix-dashboard

* Cargo bug workaround (#1564)

* Remove mock feature
* Bump versions
* Script to publish runtime packages
* Merge branch 'staging' into wasm32_fix

* Fix bad test in near-vm-logic (#1565)

* Fix bad test in near-vm-logic
* Merge refs/heads/staging into bad_test

* adding genesis tools for stakewars into dockerfile (#1567)

* adding genesis tools for stakewars into dockerfile
* Merge branch 'staging' into genesis-tool-docker
* Merge refs/heads/staging into genesis-tool-docker

* Fix unused return values in serialization (#1568)

* Fix unused return values in serialization
* Merge refs/heads/staging into bad_borsh

* Update borsh to 0.2.9 (#1566)

* Update borsh to 0.2.9
* Merge refs/heads/staging into update_borsh
* Merge refs/heads/staging into update_borsh
* Merge refs/heads/staging into update_borsh
* Merge refs/heads/staging into update_borsh

* update bootnode ip (#1569)

* update bootnode ip
* Merge branch 'staging' into update-bootnode
* Merge refs/heads/staging into update-bootnode

* Fix chunk producer kickout (#1571)

* Fix chunk producer kickout

* fix genesis

* fix initialization

* Script to start nodes for stakewars (#1572)

* Scripts to start nodes for stakewars

* change chain-id

* fix quotes

* do not override if genesis already exists

* ext-costs moved to logic config extracted (#1417)

* gas_counter moved to mod

* instrumented runtime with gas counter

* hash256 per-byte gas counting added

* block_timestamp test added and fix tests

* fix genesis config

* ext-costs moved to logic config extracted

* rename Config -> VMConfig

* #49: cargo fmt all & add CI check (#1574)

* Fix typo: Secp2561KSignature -> Secp256K1Signature (#1518)

* do not remove docker build to avoid sudo (#1583)

* do not remove docker build to avoid sudo

* Improve genesis tools (#1562)

* Improve genesis tools
* Merge refs/heads/staging into improve-genesis-tools
* Merge refs/heads/staging into improve-genesis-tools
* Merge refs/heads/staging into improve-genesis-tools
* Merge refs/heads/staging into improve-genesis-tools
* Merge refs/heads/staging into improve-genesis-tools
* extract verification code
* Merge branch 'staging' into improve-genesis-tools
* Merge branch 'staging' into improve-genesis-tools
* Merge refs/heads/staging into improve-genesis-tools

* Code ownership for genesis tools (#1584)

* Code ownership for genesis tools
* Merge branch 'staging' into genesis-ownerhsip

* Disable ban for abusing peers. (#1585)

* Add option to generate signer keys to file (#1587)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.