New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce wait for validators who are offline, remove mem leak #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…offline. Adding cache instead of unbounded hashmap to EpochManager
ilblackdragon
requested review from
evgenykuzyakov,
MaksymZavershynskyi and
SkidanovAlex
as code owners
November 5, 2019 06:46
ilblackdragon
changed the title
Reduce wait for validators who are offline
[WIP] Reduce wait for validators who are offline
Nov 5, 2019
Codecov Report
@@ Coverage Diff @@
## staging #1647 +/- ##
===========================================
+ Coverage 79.74% 79.89% +0.15%
===========================================
Files 130 130
Lines 23923 24042 +119
===========================================
+ Hits 19078 19209 +131
+ Misses 4845 4833 -12
Continue to review full report at Codecov.
|
bowenwang1996
approved these changes
Nov 10, 2019
ilblackdragon
changed the title
[WIP] Reduce wait for validators who are offline
Reduce wait for validators who are offline, remove mem leak
Nov 10, 2019
SkidanovAlex
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1639
Additionally, replacing HashMap in EpochManager with SizedCache to limit memory requirements.