Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce wait for validators who are offline, remove mem leak #1647

Merged
merged 9 commits into from Nov 10, 2019

Conversation

ilblackdragon
Copy link
Member

Fixes #1639

Additionally, replacing HashMap in EpochManager with SizedCache to limit memory requirements.

…offline. Adding cache instead of unbounded hashmap to EpochManager
@ilblackdragon ilblackdragon changed the base branch from master to staging November 5, 2019 06:46
@ilblackdragon ilblackdragon changed the title Reduce wait for validators who are offline [WIP] Reduce wait for validators who are offline Nov 5, 2019
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #1647 into staging will increase coverage by 0.15%.
The diff coverage is 97.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1647      +/-   ##
===========================================
+ Coverage    79.74%   79.89%   +0.15%     
===========================================
  Files          130      130              
  Lines        23923    24042     +119     
===========================================
+ Hits         19078    19209     +131     
+ Misses        4845     4833      -12
Impacted Files Coverage Δ
chain/chain/src/types.rs 97.29% <ø> (ø) ⬆️
core/primitives/src/transaction.rs 79.45% <ø> (ø) ⬆️
near/tests/tx_propagation.rs 95.5% <0%> (-1.05%) ⬇️
chain/client/src/client_actor.rs 82.77% <100%> (+0.69%) ⬆️
chain/client/src/types.rs 81% <100%> (+5.48%) ⬆️
near/src/runtime.rs 71.54% <100%> (+0.23%) ⬆️
chain/chain/src/test_utils.rs 78.99% <100%> (+0.13%) ⬆️
near/src/config.rs 94.82% <100%> (+0.06%) ⬆️
chain/epoch_manager/src/types.rs 76% <100%> (+20.15%) ⬆️
chain/epoch_manager/src/lib.rs 96.77% <98.88%> (+0.21%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f1c5c...e3d0bbb. Read the comment docs.

chain/client/src/client_actor.rs Outdated Show resolved Hide resolved
@ilblackdragon ilblackdragon changed the title [WIP] Reduce wait for validators who are offline Reduce wait for validators who are offline, remove mem leak Nov 10, 2019
chain/client/src/client_actor.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants