Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client TX limiting #1657

Merged
merged 36 commits into from Nov 18, 2019
Merged

Client TX limiting #1657

merged 36 commits into from Nov 18, 2019

Conversation

@evgenykuzyakov
Copy link
Collaborator

evgenykuzyakov commented Nov 6, 2019

This is part 3. See [part 1] and [part 2].

  • Filter transactions using Draining Iterator from the pool.
  • The order is defined by nearprotocol/nomicon#5
  • Removing ValidTransaction and Pool errors.

Fixes #1579
Ref #1507

@evgenykuzyakov evgenykuzyakov requested a review from nearmax Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #1657 into staging will increase coverage by 0.29%.
The diff coverage is 93.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1657      +/-   ##
===========================================
+ Coverage     80.2%   80.49%   +0.29%     
===========================================
  Files          131      131              
  Lines        24862    25038     +176     
===========================================
+ Hits         19941    20155     +214     
+ Misses        4921     4883      -38
Impacted Files Coverage Δ
chain/chunks/src/types.rs 25% <ø> (+6.25%) ⬆️
chain/client/src/types.rs 82.65% <ø> (+1.65%) ⬆️
chain/chain/src/types.rs 99.05% <ø> (+1.83%) ⬆️
chain/chain/src/lib.rs 100% <ø> (ø) ⬆️
chain/client/tests/challenges.rs 92.79% <100%> (ø) ⬆️
chain/chunks/src/lib.rs 93.92% <100%> (-0.03%) ⬇️
core/primitives/src/block.rs 97.47% <100%> (ø) ⬆️
core/primitives/src/sharding.rs 98.95% <100%> (-0.01%) ⬇️
chain/chain/src/test_utils.rs 84.76% <100%> (+7.65%) ⬆️
core/crypto/src/signature.rs 94.18% <66.66%> (-0.74%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b2252...4fb8e71. Read the comment docs.

near/src/runtime.rs Outdated Show resolved Hide resolved
chain/client/src/client.rs Outdated Show resolved Hide resolved
@evgenykuzyakov evgenykuzyakov changed the base branch from tx-limiting to staging Nov 13, 2019
@evgenykuzyakov evgenykuzyakov changed the title [PART 3] Client TX limiting Client TX limiting Nov 13, 2019
@evgenykuzyakov

This comment has been minimized.

Copy link
Collaborator Author

evgenykuzyakov commented Nov 13, 2019

Going to add comments before review

@nearmax

This comment has been minimized.

Copy link
Collaborator

nearmax commented Nov 15, 2019

Is it ready for another review?

@evgenykuzyakov

This comment has been minimized.

Copy link
Collaborator Author

evgenykuzyakov commented Nov 15, 2019

Is it ready for another review?

@nearmax Ready

@evgenykuzyakov evgenykuzyakov requested a review from nearmax Nov 16, 2019
@evgenykuzyakov evgenykuzyakov merged commit 07941ad into staging Nov 18, 2019
3 checks passed
3 checks passed
codecov/patch 93.62% of diff hit (target 80.2%)
Details
codecov/project 80.49% (+0.29%) compared to 89b2252
Details
gitlab-ci
Details
@evgenykuzyakov evgenykuzyakov deleted the client-tx-limiting branch Nov 18, 2019
SkidanovAlex added a commit that referenced this pull request Nov 19, 2019
This reverts commit 07941ad.
SkidanovAlex added a commit that referenced this pull request Nov 19, 2019
This reverts commit 07941ad.
evgenykuzyakov added a commit that referenced this pull request Nov 19, 2019
SkidanovAlex added a commit that referenced this pull request Nov 19, 2019
* Revert "Revert "Client TX limiting (#1657)" (#1721)"

This reverts commit bbeed12.

* Reintroduce valid transactions back to the pool
@bowenwang1996 bowenwang1996 mentioned this pull request Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.