Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixing chunks retrieval for non-validators #1660
@@ Coverage Diff @@ ## staging #1660 +/- ## =========================================== - Coverage 79.42% 79.24% -0.18% =========================================== Files 128 128 Lines 23142 23099 -43 =========================================== - Hits 18380 18305 -75 - Misses 4762 4794 +32
1. Properly fixing the case when a node is not a validator and doesn't need to request any chunks. 2. Allow fetching chunks that are outside of the cache horizon, and only use the horizon for unknown chunks.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.