Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing chunks retrieval for non-validators #1660

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

@SkidanovAlex
Copy link
Member

SkidanovAlex commented Nov 7, 2019

  1. Properly fixing the case when a node is not a validator and doesn't need to request any chunks.
  2. Allow fetching chunks that are outside of the cache horizon, and only use the horizon for unknown chunks.
@SkidanovAlex SkidanovAlex requested a review from ilblackdragon as a code owner Nov 7, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #1660 into staging will decrease coverage by 0.17%.
The diff coverage is 87.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1660      +/-   ##
===========================================
- Coverage    79.42%   79.24%   -0.18%     
===========================================
  Files          128      128              
  Lines        23142    23099      -43     
===========================================
- Hits         18380    18305      -75     
- Misses        4762     4794      +32
Impacted Files Coverage Δ
chain/client/src/client.rs 90.85% <ø> (+0.01%) ⬆️
chain/network/src/peer.rs 77.56% <0%> (-0.39%) ⬇️
chain/client/src/sync.rs 85.38% <100%> (-0.79%) ⬇️
chain/chain/src/chain.rs 91.1% <100%> (+0.11%) ⬆️
near/src/config.rs 94.73% <100%> (-0.03%) ⬇️
chain/client/src/client_actor.rs 83.65% <100%> (-0.3%) ⬇️
chain/chunks/src/chunk_cache.rs 83.33% <68.75%> (-2.88%) ⬇️
chain/chunks/src/lib.rs 93.94% <91.3%> (-0.57%) ⬇️
chain/client/src/lib.rs 0% <0%> (-100%) ⬇️
chain/jsonrpc/src/metrics.rs 50% <0%> (-16.67%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4600ed9...b5f1423. Read the comment docs.

1. Properly fixing the case when a node is not a validator and doesn't need to request any chunks.
2. Allow fetching chunks that are outside of the cache horizon, and only use the horizon for unknown chunks.
@SkidanovAlex SkidanovAlex force-pushed the block-sync-more branch from 4e2267d to b5f1423 Nov 7, 2019
@SkidanovAlex SkidanovAlex merged commit a82180d into staging Nov 7, 2019
3 checks passed
3 checks passed
codecov/patch 87.87% of diff hit (target 79.42%)
Details
codecov/project Absolute coverage decreased by -0.17% but relative coverage increased by +8.45% compared to 4600ed9
Details
gitlab-ci
Details
@SkidanovAlex SkidanovAlex deleted the block-sync-more branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.