Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster bls signature decompression #672

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@david-stolp
Copy link
Collaborator

david-stolp commented Mar 5, 2019

This should speed up signature aggregation by about 4x. The new bottleneck is computing the y-coordinate during decompression. This will be fixed in a later review.

pieguy

@david-stolp david-stolp requested a review from bowenwang1996 Mar 5, 2019

@evgenykuzyakov

This comment has been minimized.

Copy link
Collaborator

evgenykuzyakov commented Mar 5, 2019

Post new benchmarks results here for historic reasons

@david-stolp

This comment has been minimized.

Copy link
Collaborator Author

david-stolp commented Mar 5, 2019

Before: 3ms per signature decompression. After: 700us. The difference is added to signature verification time, which is about 20ms total.

@david-stolp david-stolp merged commit a4b9711 into master Mar 8, 2019

1 check passed

ci/gitlab/pieguy Pipeline passed on GitLab
Details

@david-stolp david-stolp deleted the pieguy branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.