New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit example default filter #50

Open
first-timers bot opened this Issue Oct 4, 2018 · 12 comments

Comments

Projects
None yet
5 participants
@first-timers

first-timers bot commented Oct 4, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file src/filters.js in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -27,7 +27,7 @@ export var defaultFilters = {
 each of the default filters the user
 Has set to true. This opens up a realm of possibilities like autoEscape, etc.
 */
-  // e: false, // Escape is turned off by default for performance
+  // somefilter: false,
 }
 
 export var defaultFilterCache = {
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@Shashank100297

This comment has been minimized.

Show comment
Hide comment
@Shashank100297

Shashank100297 Oct 4, 2018

Hey! I would like to claim this

Shashank100297 commented Oct 4, 2018

Hey! I would like to claim this

@bsaptarshi

This comment has been minimized.

Show comment
Hide comment
@bsaptarshi

bsaptarshi Oct 4, 2018

@Shashank100297 if you're not already on to it, I'd like to claim this!

bsaptarshi commented Oct 4, 2018

@Shashank100297 if you're not already on to it, I'd like to claim this!

@Shashank100297

This comment has been minimized.

Show comment
Hide comment
@Shashank100297

Shashank100297 Oct 4, 2018

@Shashank100297 if you're not already on to it, I'd like to claim this!

Yeah, Okay

Shashank100297 commented Oct 4, 2018

@Shashank100297 if you're not already on to it, I'd like to claim this!

Yeah, Okay

@Artistic18

This comment has been minimized.

Show comment
Hide comment
@Artistic18

Artistic18 Oct 4, 2018

Contributor

I want to claim this issue.

Contributor

Artistic18 commented Oct 4, 2018

I want to claim this issue.

@Sharma-Rajat

This comment has been minimized.

Show comment
Hide comment
@Sharma-Rajat

Sharma-Rajat Oct 4, 2018

I can claim any issues like this if there are any left :)

Sharma-Rajat commented Oct 4, 2018

I can claim any issues like this if there are any left :)

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

Who wants to do it, @bsaptarshi or @Shashank100297?

Owner

nebrelbug commented Oct 4, 2018

Who wants to do it, @bsaptarshi or @Shashank100297?

@Shashank100297

This comment has been minimized.

Show comment
Hide comment
@Shashank100297

Shashank100297 Oct 4, 2018

Who wants to do it, @bsaptarshi or @Shashank100297?

I'm dropping. Let @bsaptarshi do it.

Shashank100297 commented Oct 4, 2018

Who wants to do it, @bsaptarshi or @Shashank100297?

I'm dropping. Let @bsaptarshi do it.

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

Okay, assigned to @bsaptarshi

Owner

nebrelbug commented Oct 4, 2018

Okay, assigned to @bsaptarshi

@nebrelbug nebrelbug added the assigned label Oct 4, 2018

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

@Sharma-Rajat you could work on #60, #61, #62, or #63

Owner

nebrelbug commented Oct 4, 2018

@Sharma-Rajat you could work on #60, #61, #62, or #63

@bsaptarshi

This comment has been minimized.

Show comment
Hide comment
@bsaptarshi

bsaptarshi Oct 16, 2018

@nebrelbug Can you add me as a contributor?

bsaptarshi commented Oct 16, 2018

@nebrelbug Can you add me as a contributor?

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 16, 2018

Owner

Sorry @bsaptarshi, the issue template is a little unclear. You can just start working on the issue and create a pull request. After one of your pull requests is merged, you get the title of "Contributor", but it's not required to work on it. Thanks!

Owner

nebrelbug commented Oct 16, 2018

Sorry @bsaptarshi, the issue template is a little unclear. You can just start working on the issue and create a pull request. After one of your pull requests is merged, you get the title of "Contributor", but it's not required to work on it. Thanks!

@bsaptarshi

This comment has been minimized.

Show comment
Hide comment
@bsaptarshi

bsaptarshi Oct 16, 2018

Thanks for the update, @nebrelbug, makes sense.

bsaptarshi commented Oct 16, 2018

Thanks for the update, @nebrelbug, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment