New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of lastIndex #52

Open
first-timers bot opened this Issue Oct 4, 2018 · 11 comments

Comments

Projects
None yet
6 participants
@first-timers

first-timers bot commented Oct 4, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file src/compile.js in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -11,7 +11,7 @@ import {
 import P from './partials'
 
 function Compile (str) {
-  var lastIndex = 0
+  var lastIndex = 0 // Because lastIndex can be complicated, and this way the minifier can minify more
   var funcStr = ''
   var helperArray = []
   var helperNumber = -1
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@krithika-n

This comment has been minimized.

Show comment
Hide comment
@krithika-n

krithika-n Oct 4, 2018

Hey! I would like to claim this issue

krithika-n commented Oct 4, 2018

Hey! I would like to claim this issue

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

@krithika-n awesome! Reserved πŸ‘

Owner

nebrelbug commented Oct 4, 2018

@krithika-n awesome! Reserved πŸ‘

@nebrelbug nebrelbug added the assigned label Oct 4, 2018

@catherineyeh

This comment has been minimized.

Show comment
Hide comment
@catherineyeh

catherineyeh Oct 4, 2018

Hi, I would like to claim this issue!

catherineyeh commented Oct 4, 2018

Hi, I would like to claim this issue!

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

@catherineyeh sorry, it's already been reserved. You could work on #49 or #50 though.

Owner

nebrelbug commented Oct 4, 2018

@catherineyeh sorry, it's already been reserved. You could work on #49 or #50 though.

@Artistic18

This comment has been minimized.

Show comment
Hide comment
@Artistic18

Artistic18 Oct 4, 2018

Contributor

Can i claim this issue?

Contributor

Artistic18 commented Oct 4, 2018

Can i claim this issue?

@Dravinbhatia

This comment has been minimized.

Show comment
Hide comment
@Dravinbhatia

Dravinbhatia Oct 4, 2018

Contributor

Heyy....I am new to open source.I want to claim this issue....

Contributor

Dravinbhatia commented Oct 4, 2018

Heyy....I am new to open source.I want to claim this issue....

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

@Artistic18 and @Dravinbhatia you could work on #60, #61, #62, or #63

Owner

nebrelbug commented Oct 4, 2018

@Artistic18 and @Dravinbhatia you could work on #60, #61, #62, or #63

@krithika-n

This comment has been minimized.

Show comment
Hide comment
@krithika-n

krithika-n commented Oct 4, 2018

@nebrelbug Thanks :) On it

krithika-n added a commit to krithika-n/squirrelly that referenced this issue Oct 4, 2018

@krithika-n

This comment has been minimized.

Show comment
Hide comment
@krithika-n

krithika-n Oct 4, 2018

Please review my pull request

krithika-n commented Oct 4, 2018

Please review my pull request

@jamesrbedwell

This comment has been minimized.

Show comment
Hide comment
@jamesrbedwell

jamesrbedwell Oct 18, 2018

Can I claim this issue please?

jamesrbedwell commented Oct 18, 2018

Can I claim this issue please?

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 18, 2018

Owner

@krithika-n there are just a couple of things that you need to do, that I explained on your pull request. If you won't have time within the next couple of days, would you be willing to let @jamesrbedwell work on this issue?

Owner

nebrelbug commented Oct 18, 2018

@krithika-n there are just a couple of things that you need to do, that I explained on your pull request. If you won't have time within the next couple of days, would you be willing to let @jamesrbedwell work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment