New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarifications to broken-down regEx #60

Open
first-timers bot opened this Issue Oct 4, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@first-timers

first-timers bot commented Oct 4, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file src/regexps.js in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -45,9 +45,10 @@ export function replaceParamHelpers (params) {
   })
   return params
 }
-// The initial RegExp broken down:
+// The whole regular expression can be hard to comprehend, so here it's broken down.
+// You can pass the string between "START REGEXP" and "END REGEXP" into a regular expression
+// That removes whitespace and comments, and outputs a working regular expression.
 
-// Total RegEx:
 /* START REGEXP
 {{ *? //the beginning
 (?: //or for each possible tag
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@1Oozaru1

This comment has been minimized.

Show comment
Hide comment
@1Oozaru1

1Oozaru1 Oct 4, 2018

I would like to claim this issue.

1Oozaru1 commented Oct 4, 2018

I would like to claim this issue.

@Artistic18

This comment has been minimized.

Show comment
Hide comment
@Artistic18

Artistic18 Oct 4, 2018

Contributor

Can i work on it?

Contributor

Artistic18 commented Oct 4, 2018

Can i work on it?

@ptella

This comment has been minimized.

Show comment
Hide comment
@ptella

ptella Oct 4, 2018

Can I work on it please?

ptella commented Oct 4, 2018

Can I work on it please?

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

Great! Reserved for @1Oozaru1.

Owner

nebrelbug commented Oct 4, 2018

Great! Reserved for @1Oozaru1.

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 4, 2018

Owner

@Artistic18 you can work on the next issue that opens up.

Owner

nebrelbug commented Oct 4, 2018

@Artistic18 you can work on the next issue that opens up.

@nebrelbug nebrelbug added the assigned label Oct 4, 2018

@Artistic18

This comment has been minimized.

Show comment
Hide comment
@Artistic18

Artistic18 Oct 4, 2018

Contributor

ok thanks

Contributor

Artistic18 commented Oct 4, 2018

ok thanks

@electricgnome

This comment has been minimized.

Show comment
Hide comment
@electricgnome

electricgnome Oct 5, 2018

Hi, I'd like to claim this issue

electricgnome commented Oct 5, 2018

Hi, I'd like to claim this issue

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 5, 2018

Owner

@electricgnome this issue is already reserved, but you could work on #87 or another issue with the 'available' label.

Owner

nebrelbug commented Oct 5, 2018

@electricgnome this issue is already reserved, but you could work on #87 or another issue with the 'available' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment