New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to example Sqrl file #85

Closed
first-timers bot opened this Issue Oct 5, 2018 · 12 comments

Comments

Projects
None yet
4 participants
@first-timers

first-timers bot commented Oct 5, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file examples/views/index.sqrl in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -4,7 +4,8 @@
     <title>{{title}}</title>
   </head>
   <body>
+    {{!--comment--}}
     <p>It works!</p>
 
   </body>
-</html>
\ No newline at end of file
+</html>
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@dlarner3194

This comment has been minimized.

Show comment
Hide comment
@dlarner3194

dlarner3194 Oct 5, 2018

Contributor

I'll grab this one

Contributor

dlarner3194 commented Oct 5, 2018

I'll grab this one

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 5, 2018

Owner

@dlarner3194 since you've already contributed, will you work on a different, not 'first-timers-only' issue? Maybe you could work on #65. Thanks for your enthusiasm!

Owner

nebrelbug commented Oct 5, 2018

@dlarner3194 since you've already contributed, will you work on a different, not 'first-timers-only' issue? Maybe you could work on #65. Thanks for your enthusiasm!

@dlarner3194

This comment has been minimized.

Show comment
Hide comment
@dlarner3194

dlarner3194 Oct 5, 2018

Contributor

@nebrelbug looks like that one has already been assigned. Can I get started on it anyways?

Contributor

dlarner3194 commented Oct 5, 2018

@nebrelbug looks like that one has already been assigned. Can I get started on it anyways?

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 5, 2018

Owner

@dlarner3194 Yes, a couple of people can be working on that issue. There's no such thing as too many resources for beginners!

Owner

nebrelbug commented Oct 5, 2018

@dlarner3194 Yes, a couple of people can be working on that issue. There's no such thing as too many resources for beginners!

@jeanha124

This comment has been minimized.

Show comment
Hide comment
@jeanha124

jeanha124 Oct 5, 2018

Contributor

can I do this one as well?

Contributor

jeanha124 commented Oct 5, 2018

can I do this one as well?

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 5, 2018

Owner

@jeanha124 sorry, this one has already been assigned. You could work on one of the other available issues though, or work on #65 (which a couple of people can be working on). Thanks!

Owner

nebrelbug commented Oct 5, 2018

@jeanha124 sorry, this one has already been assigned. You could work on one of the other available issues though, or work on #65 (which a couple of people can be working on). Thanks!

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 5, 2018

Owner

Sorry @jeanha124, just realized it hasn't been assigned πŸ˜„. You can work on it if you want.

Owner

nebrelbug commented Oct 5, 2018

Sorry @jeanha124, just realized it hasn't been assigned πŸ˜„. You can work on it if you want.

@jeanha124

This comment has been minimized.

Show comment
Hide comment
@jeanha124

jeanha124 Oct 5, 2018

Contributor

thank you

Contributor

jeanha124 commented Oct 5, 2018

thank you

@nebrelbug nebrelbug added assigned and removed available labels Oct 5, 2018

@bourguy

This comment has been minimized.

Show comment
Hide comment
@bourguy

bourguy Oct 12, 2018

Hi @nebrelbug , Can I claim that one? Looks like it is still open.
Thanks!

bourguy commented Oct 12, 2018

Hi @nebrelbug , Can I claim that one? Looks like it is still open.
Thanks!

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 12, 2018

Owner

It's assigned to @jeanha124. @jeanha124, if you're not available to work on the project within the next couple of days, could you let @bourguy work on this issue instead? Thanks!

Owner

nebrelbug commented Oct 12, 2018

It's assigned to @jeanha124. @jeanha124, if you're not available to work on the project within the next couple of days, could you let @bourguy work on this issue instead? Thanks!

@jeanha124

This comment has been minimized.

Show comment
Hide comment
@jeanha124

jeanha124 Oct 12, 2018

Contributor
Contributor

jeanha124 commented Oct 12, 2018

@nebrelbug

This comment has been minimized.

Show comment
Hide comment
@nebrelbug

nebrelbug Oct 12, 2018

Owner

@jeanha124 I reviewed your pull request, but it must not have sent you a notification :). Just click on the pull request and you should be able to see it. Thanks!

Owner

nebrelbug commented Oct 12, 2018

@jeanha124 I reviewed your pull request, but it must not have sent you a notification :). Just click on the pull request and you should be able to see it. Thanks!

@nebrelbug nebrelbug closed this Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment