This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Unable to override not initialized Boolean property with false value #1
Comments
szpak
added a commit
to szpak-forks/gradle-override-plugin
that referenced
this issue
Oct 6, 2014
…olean property with false value Broken test is ignored.
Thanks for reporting. If you open the pull request, please open it against the |
Too late :(. I created at against Nevertheless if you prefer I can create another PR. |
Yes, can you please close the pull request and reopen. Thanks! |
szpak
added a commit
to szpak-forks/gradle-override-plugin
that referenced
this issue
Oct 6, 2014
…olean property with false value Broken test is ignored.
I rebased my branch. The old PR should be already against gradle-1.12. |
szpak
added a commit
to szpak-forks/gradle-override-plugin
that referenced
this issue
Oct 6, 2014
…olean property with false value Broken test is ignored.
I created a new PR. |
bmuschko
added a commit
that referenced
this issue
Oct 9, 2014
#1 - Reproduce problem with override not initialized Boolean property
bmuschko
added a commit
that referenced
this issue
Oct 9, 2014
bmuschko
added a commit
that referenced
this issue
Oct 9, 2014
Issue #1: Determine property type if no value is assigned.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A try to override not initialized Boolean property like below:
with
false
valueends with
true
value assigned.After some debugging the problem is in
DotNotationWalkerOverrideStrategy
.determineProperty()
for not initialized field property it returnsnull
and clazz is set toNullObject
.parent.setProperty
doesn't know that is a Boolean field and setfalse
asString
and for Groovy istrue
.It would be required to get a type of not initialized property in Groovy object, but I don't know if Groovy offers that information.
In a few minutes I will make a pull request with test reproducing that case.
The text was updated successfully, but these errors were encountered: