Fix a bug that was breaking shell-strip-env #11
Conversation
name would be first arg in &rest * Fix activate on windows - do not use "source", and add a newline to the command * Replace an ad-do-it with (apply orig-fun...) - seems like advice-add doesn't provide ad-do-it?
|
@monomon Thank you so much for this PR! I've been trying to figure out how best to replicate #10 -- I don't use Windows, and honestly don't use Elisp code looks good -- Indeed, Looking at other best-practices, it seems sending a newline after the activate command doesn't hurt on any OS, so it might be worth factoring that out into a separate call that's sent regardless of the OS. Otherwise, this looks great, thank you again @monomon ! |
|
@necaris thank you for the response. I too do not use Windows voluntarily, but now will be on it extensively for a specific project, so I could do some more testing on the package under Windows. Seems like the CI is not configured properly? Could I help in this respect? |
|
@monomon the CI is failing because there aren't actually any useful tests -- I've got a branch I'm working on to add tests, hoping to have this working as expected this weekend. In the meantime I'll go ahead and merge this PR, looking forward to more bugs you report on Windows! |
the command
doesn't provide ad-do-it?