Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize background color #341

Closed
wants to merge 1 commit into from

Conversation

EvanHahn
Copy link

Most browsers set white as the default background, but not all. When reading in "night mode", Pocket defaults to having a dark background for web pages. This renders some pages unreadable. This aims to fix that for sites using normalize.css.

This PR doesn't update version numbers or the changelog, but it can!

Most browsers set white as the default background, but not all. When
reading in "night mode", Pocket defaults to having a dark background for
web pages. This renders some pages unreadable. This aims to fix that for
sites using normalize.css.
@battaglr
Copy link
Contributor

If I'm not wrong, this was already done and resulted problematic, check #193.

@EvanHahn
Copy link
Author

Why wouldn't normalize.css be the first thing you include in your CSS? (This is an ignorance question, not a foot-stomping "why don't you like my idea" question.)

@necolas
Copy link
Owner

necolas commented Jun 11, 2014

More details in: 71d6cdc

Example of when you might have CSS before normalize: user/page-specific settings that are dynamically rendered in a <style> block before your main stylesheet. We had this requirement when making Tweet Cards for Twitter, where the base link styles and background color needed to be dynamically based on the styles in the host app (e.g., twitter.com, TweetDeck, Syndicated Tweets).

@necolas necolas closed this Jun 11, 2014
@EvanHahn
Copy link
Author

Okay. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants