New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cursor: pointer; to [role="button"] to fix #371 #379

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@cvrebert

cvrebert commented Oct 22, 2014

Fixes #371.

Add cursor: pointer; to [role="button"] to fix #371
* Address cursor inconsistency between `button` and `[role="button"]`
* Work around Safari element clickability issue, at least for
  button-ish widgets with `[role="button"]`. Such widgets should have
  the role for proper accessibility anyway. See also
  https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile
@necolas

This comment has been minimized.

Owner

necolas commented Mar 30, 2015

I think we're going to remove the pointer styles. I appreciate that there's an iOS bug; some JS frameworks fix this, otherwise it could go in app base styles if that's how you like to roll.

@necolas necolas closed this Mar 30, 2015

cvrebert added a commit to twbs/bootstrap that referenced this pull request Apr 22, 2015

cvrebert added a commit to twbs/bootstrap that referenced this pull request Oct 25, 2015

necolas/normalize.css#379 was rejected
Refs #15947
Somehow c256aca got lost during the SCSS translation...

[skip sauce]

cvrebert added a commit to twbs/bootstrap that referenced this pull request Nov 13, 2015

Revert "Drop cursor pointer for button role"
This reverts commit 6106730.

The normalize.css pull request (necolas/normalize.css#379 )
was REJECTED, *NOT* merged!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment