React Native 0.60 tasks

[necolas]

Tasks related to changes in React Native 0.60.

• Migrate docs and RNTester examples to storybook
• Update project dependencies
• Add touchable support to Text (Text: onLongPress support #1011) (@DaKaZ)
• Add flow types for ScrollView
• Add flow types for View
• Add flow types for Text
• Add flow types for styles
• Update Touchable snapshot (@necolas)
• Update TouchableHighlight snapshot (@necolas)
• Update TouchableOpacity snapshot (@necolas)
• Update TouchableWithoutFeedback snapshot (TouchableHighlight crashes when children are wrapped in Fragment #1105) (@necolas)
• Add forwardedRef prop to Text
• Add forwardedRef prop to View
• Add accessibilityState
• Add accessibilityRelationship
• Remove accessibilityStates
• Remove accessibilityTraits
• Remove accessibilityComponentType
• Replace context.isInAParentText w/ React.createContext (@awinograd)
• Update ListView snapshot (Requires types for ScrollView) (@necolas)
• Update PanResponder snapshot
• Update SwipeableListView snapshot
• Add deprecation warnings for className (Notice: intent to deprecate and remove className prop from View and Text #1146) (@necolas)
• Merge StyleSheet default layout optimisations (StyleSheet: layout optimizations and fixes to setNativeProps #1136, [change] Introduce static CSS base rules for core primitives #1165) (@necolas)
• Upgrade Flow (Upgrade Flow #1171) (@necolas)
• Upgrade Babel (Upgrade to Babel 7 #1170) (@necolas)
• Update Animated snapshot (@necolas)
• Update Batchinator snapshot (@necolas)
• Update FillRateHelper snapshot
• Update FlatList snapshot (@necolas)
• Update NativeEventEmitter snapshot
• Update SectionList snapshot (@necolas)
• Update SwipeableFlatList snapshot (@necolas)
• Update ViewabilityHelper snapshot
• Update VirtualizeUtils snapshot
• Update VirtualizedList snapshot (@necolas)
• Update VirtualizedSectionList snapshot (@necolas)
• Change accessibility props (New accessibility props #1112) (@necolas)

Afterwards:

• Add accessibilitySetSize
• Add accessibilityPosInSet
• Add direction (inc none)
• Remove accessible
• Add focusable
• Remove enzyme

[jstheoriginal]

Are the update snasphot tasks simply taking the appropriate folder from RN 0.57 and replacing the folder in this project? If not, do you have the steps required for that type of task?

Also, should we work off of RN 0.57.4 tag? https://github.com/facebook/react-native/tree/v0.57.4

[necolas]

Updated the OP. RN 0.57.5. Snapshots are of files, not directories. You'll also need to handle updating any new import paths or dependencies

[unindented]

I'll try to take a look at Replace context.isInAParentText w/ React.createContext, see if it's too big for me.

[necolas]

I accidentally wiped out a bunch of commits on the react-native-0.57 branch because I forgot to pull down changes I pushed from another computer. Need to fix that when I'm back in SF

[evelant]

I'm also curious about this issue. Won't apps using < 0.59 start being rejected from app stores starting in August because of 64bit? After that point it will more or less be impossible to use an old version like 0.55.

[asgvard]

Latest RNW works fine with RN 0.59, just officially not supported.
However would be appreciated to have any guidance to finish these tasks, I guess ppl just need one clear example on what does it mean to update snapshots and how to do it :)

[piranna]

Latest RNW works fine with RN 0.59, just officially not supported.

What does it needs to get to be officially supported (besides an update in README.md :-) )?

[tastafur]

Hello,
I would like to make these three tasks @necolas .
Update RNTester snapshot
Add forwardedRef prop to Text
Add forwardedRef prop to View
Do I open an issue with your Pull Request for each task?

[tastafur]

Hello,
@necolas In this task Update RNTester snapshot, what you want to do is add test snapshot to all RNTester components?

[prade]

I have RNW working with RN 0.60 after doing multiple config overrides using webpack and babel, but unable to get a production build. Waiting for official support so we can override the hacks.
Thanks for the library @necolas , this definitely is the future for react development.

Latest RNW works fine with RN 0.59, just officially not supported.
However would be appreciated to have any guidance to finish these tasks, I guess ppl just need one clear example on what does it mean to update snapshots and how to do it :)

[piranna]

@prade can you be able to publish your hacks in a pull-request? This way they could be easier merged in master.

[piranna]

And not only that, that also they could be used by others.

[tastafur]

Hello
I would like to contribute to these tasks that I have to do? @necolas

[necolas]

Decided not to add more onPress props to Text for the reasons given here #1272 (comment)

I've been thinking about this feature for a while, and I think I'm going to exclude it from web by design. Apps like Twitter are using Text everywhere and adding the build and runtime overhead of Touchable to Text is (on balance) going to make the most common use of Text become more expensive. I think RN is doing too much in Text (it didn't use to overload it with press functionality) vs View, and RN should probably redesign its exports to include something like TouchableText.

[necolas]

Updating babel-plugin-tester is currently blocked on babel-utils/babel-plugin-tester#50.

Edit: babel-plugin-tester's unit tests didn't catch the change, and the author closed the issue. I will stick with v5 and stop using babel-plugin-tester in the future. Alternatives: https://babeljs.io/docs/en/next/babel-helper-plugin-test-runner.html, https://github.com/satya164/babel-test

[kopax]

Helo, I am just discovering react-native and I wonder if I should use it for the cross platforme native and web app I want to build.

I see that 0.60 of react-native is out but this is blocked for a while and there's no milestone or release date for this. Can I have you people users opinions, should I expect to be able to upgrade to 0.60 without pain the future if I start building my app with react-native-web or should I just not use react-native-web ?

Thanks for sharing !

[mykhailo-melnyk]

@kopax
I am also interested in this

[kopax]

I still do not have my answer and so far I have expo, and making my own. I have not decided yet. Not sure if this should be use, but shouldn't be too hard to make your own react-native-web I am also thinking this as a solution.

[necolas]

I don't know what you're asking. Nothing is blocked on anything and Expo uses RNW with RN 0.60. I'm going to close comments on this issue because they're not helpful and most of the work is complete and will land in master in good time