Problems with UMD build #320

Open
necolas opened this Issue Jan 5, 2017 · 6 comments

Projects

None yet

2 participants

@necolas
Owner
necolas commented Jan 5, 2017

What is the current behavior?

The unofficial UMD build for use in codepen et al has some issues.

  1. addComponentAsRefTo(...): Only a ReactOwner can have refs when using TouchableHighlight (#319). Example

  2. Using Image can throw an error about accessing source of undefined.

What is the expected behaviour?

No issues!

Environment (include versions)

OS: Any
Device: Any
Browser: Any
React Native for Web (version): At least 0.0.60 upwards
React (version): 15.4.1

@necolas necolas added the help wanted label Jan 5, 2017
@user471
user471 commented Jan 5, 2017

I used browserify instead of webpack and the result doesn't have this error.

@necolas
Owner
necolas commented Jan 5, 2017

Cool, might be a misconfiguration in the webpack config. Are you bundling the whole of React in there? Also maybe try rollup since it produces smaller, faster bundles.

@user471
user471 commented Jan 5, 2017

Are you bundling the whole of React in there?

No. browserify dist/index.js -o ReactNative.js

@necolas
Owner
necolas commented Jan 5, 2017

React is imported within the project though

@user471
user471 commented Jan 5, 2017

The file has similar size to webpack version and doesn't work without react.js

@necolas
Owner
necolas commented Jan 5, 2017

OK that sounds promising! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment