Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1011 - adds touchable event handlers to text #1272

Closed
wants to merge 2 commits into from

Conversation

DaKaZ
Copy link

@DaKaZ DaKaZ commented Mar 4, 2019

This is my second attempt to close issue #1011. This borrows much from the react-native Text component (https://github.com/facebook/react-native/blob/master/Libraries/Text/Text.js) but modifies the approach to handle web specific events like mousedown and mouseup and mouseout.

@DaKaZ DaKaZ mentioned this pull request Mar 4, 2019
44 tasks
@necolas necolas added this to the 0.12.0 milestone Mar 6, 2019
@necolas necolas self-assigned this Jul 2, 2019
@DaKaZ
Copy link
Author

DaKaZ commented Aug 15, 2019

@necolas did you want me to update this PR... just let me know

@necolas
Copy link
Owner

necolas commented Oct 7, 2019

Thanks for this PR, it looks good. However, I've been thinking about this feature for a while, and I think I'm going to keep it excluded from web by design. Apps like Twitter are using Text everywhere and adding the build and runtime overhead of Touchable to Text is (on balance) going to make the most common use of Text become more expensive. I think RN is doing too much in Text (it didn't use to overload it with press functionality either) vs View, and RN should probably redesign its exports to include something like TouchableText.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants