New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block_fn_mentor.php line 206 #44

Closed
ned-code opened this Issue Feb 15, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@ned-code
Owner

ned-code commented Feb 15, 2017

In block_fn_mentor.php line 206 looks wrong:

if ($students = block_fn_mentor_get_mentees_by_mentor(0, $filter, $USER->id)) {

as '$filter' will be an SQL thing and yet the function block_fn_mentor_get_mentees_by_mentor can expect either 'teacher' or 'mentor'?

@ned-code

This comment has been minimized.

Show comment
Hide comment
@ned-code

ned-code May 3, 2018

Owner

This is not a bug

Owner

ned-code commented May 3, 2018

This is not a bug

@ned-code ned-code closed this May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment