New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use format_string for course names #42

Merged
merged 2 commits into from Feb 13, 2017

Conversation

Projects
None yet
3 participants
@mkpelletier
Contributor

mkpelletier commented Jan 19, 2017

Any course names in which the mlang filters are active did not render. I have used format_string() to accommodate this. I created a variable for this, but it could probably be incorporated directly into the anchor tag, but I think we would need to use the html_writer() function to do this. I fear that is a bigger job so I did not want to undertake that yet.

mkpelletier added some commits Jan 19, 2017

Update course_overview.php
Allow mlang filters to process language strings in course titles.
Update course_overview_single.php
Use format_string for course fullname so mlang filters can process any language strings
@ned-code

This comment has been minimized.

Show comment
Hide comment
@ned-code

ned-code Jan 25, 2017

Owner

Hello Mathieu, I sent an email to your gmail account. Just wondering if you got it. Thanks.

Owner

ned-code commented Jan 25, 2017

Hello Mathieu, I sent an email to your gmail account. Just wondering if you got it. Thanks.

@mgardener mgardener merged commit 7f48cdd into ned-code:master Feb 13, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment