Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap unit test ought to be substantially improved #181

Closed
ned14 opened this issue Apr 3, 2019 · 1 comment

Comments

@ned14
Copy link
Owner

commented Apr 3, 2019

It looks like std::is_nothrow_swappable is broken on libstdc++. The swap unit test does a poor job of testing conformance of the swap() function to the specification, and it ought to be substantially improved.

@ned14 ned14 added the bug label Apr 15, 2019

ned14 added a commit that referenced this issue Jun 23, 2019
Implemented first half of fixing issue #181, where the strong guarant…
…ee for result swaps is now working correctly.

@ned14 ned14 added this to the Boost 1.71 cutoff milestone Jun 24, 2019

ned14 added a commit that referenced this issue Jun 25, 2019
Fix issue #181 where Outcome didn't actually implement the strong swa…
…p guarantee,

despite being documented as doing so.
@ned14

This comment has been minimized.

Copy link
Owner Author

commented Jun 25, 2019

Fixed!

@ned14 ned14 closed this Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.