Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
version.hpp has no include guards and license header #184
I believe I can craft a licence which won't confuse the cmake parsers, so consider that done.
However the version and revision headers are deliberately and unintentionally guarded. I want them to warn when incompatible versions get mixed into the same translation unit.
Can I relocate them into detail, and you would be happy?
The way they are now, they will warn about macro redefinitions regardless of whether the versions are the same or different.
Sure, that would make them private, that'd be fine.
Compilers only warn if the macro definition changes. You can repeat a definition as many times as you like, so long as it is identical. This is specifically what I want to canary to end users.
I'll leave this issue open to remind me to make these changes, but be aware they will land no earlier than after the Cologne WG21 meeting, sorry. I have a hideous non-work workload between now and then. But all bug fixes to Outcome should land well in time for the August release.