Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function definition duplicated between boost and standalone version #192

Closed
BurningEnlightenment opened this issue Jun 22, 2019 · 1 comment

Comments

@BurningEnlightenment
Copy link

commented Jun 22, 2019

namespace std // NOLINT
{
inline exception_ptr basic_outcome_failure_exception_from_error(const error_code &ec) { return make_exception_ptr(system_error(ec)); }
} // namespace std

This function is defined by the boost and the standalone version, but do not share the same include guard which in turn leads to a symbol redefinition compile error if both versions are included in the same translation unit.

@ned14 ned14 added this to the Boost 1.71 cutoff milestone Jun 22, 2019

ned14 added a commit that referenced this issue Jun 22, 2019
Fix issue #192 where the `std::basic_outcome_failure_exception_from_e…
…rror()`

was being defined twice for translation units which combine standalone and
Boost Outcome's.

@ned14 ned14 added the bug label Jun 22, 2019

@ned14

This comment has been minimized.

Copy link
Owner

commented Jun 22, 2019

Nice catch. And perfect timing too, today is the cutoff for Boost 1.71. Now fixed. Thank you!

@ned14 ned14 closed this Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.