-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage gevent looks broken #149
Comments
Original comment by Anonymous Confirmed, gevent breaks coverage :( |
Issue #177 was marked as a duplicate of this issue. |
Here's a fix, though it sacrifices other behavior: https://github.com/newbrough/coverage |
Issue #209 was marked as a duplicate of this issue. |
Original comment by krw1243 (Bitbucket: krw1243, GitHub: Unknown) Hi Ned, wondering if you could describe what behavior the newbrough branch sacrifices for someone who doesn't have a deep understanding of coverage.py and gevent internals, so we can decide if this fix would be appropriate for our project (which uses gevent)? |
Original comment by Vadim Fint (Bitbucket: mocksoul, GitHub: mocksoul) This monkey patch fixed coverage to work with gevent for me:
|
Vadim, thanks, this will help as I evaluate solutions. Just one question: why did you use |
Hmm, ok, strange what people value in code.... |
Original comment by Vadim Fint (Bitbucket: mocksoul, GitHub: mocksoul) "Import statement" at the end of meth looks ugly while But anyway, this is more strange for me:
You are right, it is strange what people value in code... :- |
Those are better reasons than "one line of code." :) And it's even worse on my machine for some reason:
|
Original comment by Brian Wylie (Bitbucket: brifordwylie, GitHub: brifordwylie) The workbench project really needs gevent coverage https://github.com/SuperCowPowers/workbench. The project used to use nosetests and we pulled in https://github.com/newbrough/coverage.git. With that configuration we were getting about 94% coverage. We upgraded to pytest and the latest version complains/won't run with the github version of coverage above. So we switched to using the 'stock' coverage module and now we have a coveralls badge that is RED and kinda embarrassing :) Would it be possible to contract someone to put in the support for gevent? Elance contract perhaps? Happy to support this work because we'd really like to have our coverage badge not be red all the time, kinda erodes confidence in an embryonic project like ours.. :) Cheers, |
@Brianwylie There is some nascent support for gevent in the current coverage.py code, but it needs a lot of love. I am happy to talk about possibilities for getting it done. |
@mocksoul I'm trying to adapt your solution, but getting odd results. Any chance you could help me understand what's going on? |
Original comment by Brian Wylie (Bitbucket: brifordwylie, GitHub: brifordwylie) Hi Ned, I also tried Vadim's patch and it didn't work for me either. Vadim said he wasn't surprised as these things go I think it was more a quick patch on a particular version than meant to be anything more long lasting. I ran the test 'test_gevent.py' above.. and after some random tinkering noticed that I would occasionally get a thread KeyError exception thrown at the very end (was playing with gevent monkey patching). I found this thread on SO http://stackoverflow.com/questions/8774958/keyerror-in-module-threading-after-a-successful-py-test-run. I think it might be a good place to start... to be honest it's deeper than my knowledge, so I'll just have to hope the pointer helps. :) Replication Instructions:
Just wanted to say that the workbench project ^appears^ to be getting exactly correct coverage with coveragepy 4.0a0 version (Github).. it's a complicated project (client/server) with tons of gevent calls (using ZeroRPC).. so that is a data point that perhaps the 4.0a0 version of coverage IS working on gevent calls, there's just some weird corner case at the very end of the program... perhaps with this thread KeyError exception getting thrown. |
Finally finished with 4ab31534f129 (bb), though more work to get it working with the C tracer. |
Original comment by Arnold Krille (Bitbucket: kampfschlaefer, GitHub: kampfschlaefer) Sadly it seems to me as if its not working. I created a small project to reproduce the issue: https://github.com/kampfschlaefer/gevent_covtest It might be I am doing something wrong as I started using gevent only a week ago. But I don't think my code is wrong as it does what I want it to do... |
@kampfschlaefer There's no .coveragerc in that repo, so it looks to me like you haven't set the "concurrency" setting. Create a .coveragerc file like this:
and try it again. |
Original comment by Arnold Krille (Bitbucket: kampfschlaefer, GitHub: kampfschlaefer) Thanks, that did it! |
Original comment by Jason Madden (Bitbucket: jamadden, GitHub: jamadden) I'm a maintainer of gevent itself, and I wanted to give a big shoutout to everyone who helped get this working. I've recently been able to enable this for gevent (here's the coveralls page) and it will be a big help to ensure gevent's quality moving forward. There are still some rough edges---some of the results aren't quite right---but I think that's more due to gevent's configuration and test system than anything else; overall, the coverage results make sense and look good! |
Originally reported by mardiros (Bitbucket: mardiros, GitHub: mardiros)
If you run the attachement test_gevent.py, coverage doesn't mark a few line as executed.
The text was updated successfully, but these errors were encountered: