-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to contribute and run tests? #171
Comments
You are right, the test suite is complex to run, it would be better if it were more approachable. Tox does look interesting, though I would have to drop support for 2.3 in order to use it. About your stack trace, I have no idea what that is. Are you somehow mixing 32-bit and 64-bit compilation? |
Original comment by andrea crotti (Bitbucket: andrea_crotti, GitHub: Unknown) Not sure, how would I mix the compilation? Because I simply did "python setup.py develop" and it used gcc, I suppose just compiling for 64 bits since that's my architecture (archlinux by the way). About Tox well I think that the few people in the world that are still using 2.3 would not mind too much to use the coverage <= 3.5.. |
Original comment by andrea crotti (Bitbucket: andrea_crotti, GitHub: Unknown) Another problem is that in alltests.sh there is this line with an hardcoded path: but running build_ve with python2.7 that path is not generated (it's ve/27 instead) so from my understanding it' not really possible to use the test scripts unless you're running python26 as the default Python... |
I have no experience with archlinux, but I hear they do odd things like call python 3 "python", so maybe that's the problem? You are right about 2.3, changing toolsets is hard, I need to get into the proper mental state... |
Original comment by andrea crotti (Bitbucket: andrea_crotti, GitHub: Unknown) No I'm quite sure that's not the issue, since I changed the symlink long time ago ;) And how would that affect compilation of the C file? |
Python 2 and Python 3 have different header and different binary interfaces. You need to compile C extensions against the version of Python you're going to run them with. This is true for major versions also. A C extension compiled against 3.1 won't run under 3.2, for example. |
Original comment by andrea crotti (Bitbucket: andrea_crotti, GitHub: Unknown) Actually it's really really simple to set up tox.ini, I just added this file and it already does all the virtualenv dance: [tox] [testenv] And by the way py32 succeds but py26 still generates the same error with the memory that I pasted above, and since now it's tox taking care of everything I don't think it can be a problem of compilation.. |
I'm not sure why you think that an error under tox proves that the compilation isn't to blame? It's still compiling it on your system with whatever configuration you've got. |
Marc, we never did figure it out, if you can provide more clues, that would be great. |
Original comment by Marc Abramowitz (Bitbucket: msabramo, GitHub: msabramo) OK, I got past this error with Travis. I'm not exactly sure what causes it, but I think it was happening when I was executing simply:
I think when I changed it to:
it stopped happening. So my guess is that without pointing It does seem like a good idea to write a bit of documentation for how to run the tests, as it took me a little while to figure out too. I might take a stab at this a bit later, unless you'd like to do it. |
Original comment by Marc Abramowitz (Bitbucket: msabramo, GitHub: msabramo) OK, I took a stab at documenting how to run the tests at: https://bitbucket.org/ned/coveragepy/pull-request/6/take-a-stab-at-documenting-a-bit-about-how |
Marc, thanks for getting me going on this. Now that we have tox well in hand, I wrote a Contributing page modeled on yours. Fixed in <<changeset 1bc03c573b88 (bb)>>. |
Originally reported by andrea crotti (Bitbucket: andrea_crotti, GitHub: Unknown)
I've looked in the documentation but I can't find any mention about how to contribute and run the unit tests for example.
I figured out that I might need to use build_ve and all_tests but it's still failing, and I get the error below with python2.7..
Also it looks like these scripts might be replace with TOX, which is apparently a great tool!
And just a couple of paragraphs explaining how to contribute would be nice and make life easier..
Thanks
The text was updated successfully, but these errors were encountered: