Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers in HTML report do not align with source lines in Chromium #197

Closed
nedbat opened this issue Sep 25, 2012 · 4 comments
Closed
Labels
bug Something isn't working html

Comments

@nedbat
Copy link
Owner

nedbat commented Sep 25, 2012

Originally reported by Marius Gedminas (Bitbucket: mgedmin, GitHub: mgedmin)


This issue is best explained with a couple of screenshots: http://imgur.com/a/UgxK4

Chromium 21.0.1180.89 Ubuntu 12.04 (154005) on my machine thinks line-height for the line numbers is 16px exactly, while the line-height of the main code is 15.983333587646484px (which it apparently rounds down to 15px). I'm not sure what happens, exactly, but the end result is that line numbers are not aligned with the code, which makes me sad.

Changing p { line-height: 1.3333em; } to p { line-height: 1.3333333em; } is enough to fix the issue on my machine. Chromium Inspector shows that line-height of the p is computed to be 16px exactly. Removing any of the '3's after the decimal point is enough to make the problem reappear.

I've attached the patch to style.css to this issue.


@nedbat
Copy link
Owner Author

nedbat commented Sep 26, 2012

Issue #190 was marked as a duplicate of this issue.

@nedbat
Copy link
Owner Author

nedbat commented Sep 26, 2012

Fixed in <<changeset a9b31e4bf439 (bb)>>, thanks Marius!

@nedbat
Copy link
Owner Author

nedbat commented Nov 27, 2012

Issue #215 was marked as a duplicate of this issue.

@nedbat
Copy link
Owner Author

nedbat commented Feb 25, 2015

Original comment by Barry Warsaw (Bitbucket: warsaw, GitHub: warsaw)


I'm not sure this is fixed. I still see it with coverage 3.7.1 in Ubuntu.

@nedbat nedbat closed this as completed Feb 25, 2015
@nedbat nedbat added minor bug Something isn't working html labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html
Projects
None yet
Development

No branches or pull requests

1 participant