-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail_under param not working in .coveragerc #314
Comments
|
Issue #332 was marked as a duplicate of this issue. |
Implemented in fabb2d4d3720 (bb) |
Original comment by Kristian Glass (Bitbucket: DoISmellBurning, GitHub: DoISmellBurning) Could this fix see its way to a point-release please, because it's just been the cause of much confusion! |
@doismellburning I'm sorry, but this change, as small as it seems, depended on some deeper changes that are not in 3.7.1. Also, it's difficult for me to keep two development streams going on a side project. |
Original comment by Kristian Glass (Bitbucket: DoISmellBurning, GitHub: DoISmellBurning) No worries - thanks for getting back to me + all the work! :) |
Originally reported by Micah Hausler (Bitbucket: micahhausler, GitHub: micahhausler)
When I run
coverage run setup.py test
and thencoverage report
, the output properly reports the coverage at 88% and shows the missing lines, but it exits with a status of0
, where it should fail. If I add --fail-under=100` flag to the command line, it properly fails.Here is my .coveragerc file:
Coverage version is 3.7.1
TravisCI build output: https://travis-ci.org/ambitioninc/django-query-builder/jobs/29320446
The text was updated successfully, but these errors were encountered: