Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run --append doesn't create coverage file #392

Closed
nedbat opened this issue Aug 3, 2015 · 3 comments
Closed

run --append doesn't create coverage file #392

nedbat opened this issue Aug 3, 2015 · 3 comments
Labels
bug Something isn't working run

Comments

@nedbat
Copy link
Owner

nedbat commented Aug 3, 2015

Originally reported by Mattijs Ugen (Bitbucket: akaidiot, GitHub: akaidiot)


We're using something like coverage run --append --source module_name py.test tests-folder/ to run unit tests with coverage. For multi-python support, this line is run with both python2.7 and python3.4 from tox. Tox makes sure COVERAGE_FILE is set to a location that suits our build env.

This has worked great for a while, but today our versionless dependency on coverage broke this, complaining with the following error twice (for both used python versions):

Couldn't combine from non-existent path 'coverage/file'

The folder exists (file name is fictional), coverage.py 3.x created the file if it didn't exist, 4.0 breaks when it doesn't. Touching the file beforehand doesn't help; an empty file is an invalid coverage data file.

Command coverage html subsequently fails because there's no data to report.


I'm not too familiar with the current issues and sources for coverage.py, it could have something to do with #220, but I can't currently find an issue that is identical to our problem right now :)


@nedbat
Copy link
Owner Author

nedbat commented Aug 3, 2015

A definite regression, thanks for the bug report. This will be fixed shortly.

@nedbat
Copy link
Owner Author

nedbat commented Aug 4, 2015

Fixed in 8e9fd5121aae (bb)

@nedbat
Copy link
Owner Author

nedbat commented Aug 4, 2015

Original comment by Mattijs Ugen (Bitbucket: akaidiot, GitHub: akaidiot)


Took some effort to insert the current master into our build, but I can confirm this fixes our issue; thank you sir :)

@nedbat nedbat closed this as completed Aug 4, 2015
@nedbat nedbat added major bug Something isn't working run labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run
Projects
None yet
Development

No branches or pull requests

1 participant