Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"coverage combine" should error if no coverage #412

Closed
nedbat opened this issue Sep 26, 2015 · 4 comments
Closed

"coverage combine" should error if no coverage #412

nedbat opened this issue Sep 26, 2015 · 4 comments
Labels
enhancement New feature or request

Comments

@nedbat
Copy link
Owner

nedbat commented Sep 26, 2015

Originally reported by meejah (Bitbucket: meejah, GitHub: meejah)


If you run "coverage combine" and there is no .coverage file (or .coverage.* files) it will run without error and produce a .coverage that is "empty" (i.e. has the comment and then an empty dict).

It seems more intuitive that it should be an error to try and combine nothing.


@nedbat
Copy link
Owner Author

nedbat commented Oct 5, 2015

It's simple enough to make the command fail, by making Coverage.combine() raise an exception, but the nose coverage plugin calls combine early on, and it will stop working if I do this.

A little more thought...

@nedbat
Copy link
Owner Author

nedbat commented Aug 4, 2016

Original comment by John Vandenberg (Bitbucket: jayvdb, GitHub: jayvdb)


A more specific case of this is https://bitbucket.org/ned/coveragepy/issues/516/running-coverage-combine-twice-deletes-all

@nedbat
Copy link
Owner Author

nedbat commented Aug 7, 2016

Fixed in 34ae57c51cfb (bb), it would be great if you could test it out for me.

@nedbat
Copy link
Owner Author

nedbat commented Dec 27, 2016

This fix was released as part of Coverage.py 4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant